You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/09/27 20:57:20 UTC

[PR] perf(security): split oversized security SKILL.md files into linked siblings [magpie]

potiuk opened a new pull request, #1436:
URL: https://github.com/apache/magpie/pull/1436

   Second of a four-PR stack for the **security** family (#1344). It builds on the Snapshot drift PR below it.
   
   ## Summary
   
   Ten security skills were over the 500-line cap, `security-issue-import` more than four times over. Each keeps its orchestration in `SKILL.md`: golden rules, Step 0, every step heading, gates and hard rules. The elaboration moves **byte-for-byte** into sibling files one link away.
   
   - Each moved section's heading line stays in `SKILL.md`, followed by a one-line pointer, so existing `#anchors` still resolve.
   - **Evals:** when a step has an eval, the whole `## Step` section moved, and its `step-config.json` `skill_md` now points at the sibling. `step_heading` is unchanged. A checker that extracts every security eval's step section from `main` and from this branch reports **71 of 71 byte-identical**, so no eval input changed.
   - Links into moved sections from other skills now point at the sibling: `security-issue-sync` → `cve-allocate/title-normalize.md`, and `security-issue-triage` → `issue-import/duplicate-search.md`.
   - A diff of removed against added lines shows every removed line reappears in a sibling. The only exceptions are those link repoints and one `#reporter-credit-policy…` link in a moved example, which became `SKILL.md#…`.
   
   | skill | lines | `measured_tokens` (full `SKILL.md`) | siblings |
   |---|---:|---:|---|
   | issue-import | 2159 → 676 | 28,712 → 10,865 | candidate-listing, existing-tracker-dedup, duplicate-search, fix-already-public, screening-and-proposal, apply |
   | issue-triage | 1115 → 617 | 12,936 → 7,291 | gather, security-model-and-precedents, classification, proposal-composition |
   | issue-fix | 1139 → 597 | 12,692 → 6,640 | pre-implementation, implementation-plan, tracker-update |
   | issue-invalidate | 1012 → 635 | 12,153 → 7,865 | bulk, reasoning-and-canned, reporter-draft, apply, examples |
   | cve-allocate | 888 → 605 | 10,974 → 7,014 | title-normalize, tracker-updates |
   | issue-import-from-pr | 964 → 887 | 10,877 → 9,831 | reference, examples |
   | issue-import-from-md | 840 → 701 | 8,948 → 7,426 | findings-format, reference, examples |
   | issue-sync | 754 → 616 | 9,715 → 7,507 | next-step, mail-preflight (plus its existing siblings) |
   | issue-deduplicate | 711 → 505 | 7,828 → 5,676 | merge-templates |
   | issue-import-via-forwarder | 654 → 552 | 7,732 → 6,528 | handback-schema, references |
   | model-verify | 533 → 419 | 6,626 → 5,480 | helper, templates |
   
   Siblings load only when a run reaches the step that needs them. The per-invocation saving therefore depends on the path taken; the table shows the always-read part.
   
   **Not under 500 yet:** several skills are still over the line cap, mainly import-from-pr (887) and import-from-md (701). What remains is mostly eval-covered steps, the generated adversarial-review block, and the tracker-creation material that the next PR consolidates. Going further needs the wording pass.
   
   ## Type of change
   
   - [x] Skill change: `plugins/magpie-security/skills/*`, with 26 eval `step-config.json` files repointed
   
   ## Test plan
   
   - [x] `prek run --all-files` passes, including lychee, `skill-token-count`, `skill-surface-hash`, `check-doc-sync` and markdownlint
   - [x] `skill-and-tool-validate` green
   - [x] Eval inputs: 71 of 71 byte-identical against `main` (see above). Live eval runs are not repeated here because their prompts are unchanged.
   
   ## Found, not changed (behaviour fixes, going to a separate PR)
   
   - `security-issue-import` Steps 2a/2b/2c skip candidates by a class that is only assigned in Step 3.
   - `security-issue-triage` says "one of the five classes" in Step 5; there are six.
   - `security-issue-sync` Step 0 says PonyMail "degrades quietly", which contradicts the `mandatory: yes` hard stop in `mail-preflight.md`.
   - `security-issue-invalidate`: its Prerequisites section and 5d disagree on the default Gmail backend.
   - `security-issue-invalidate` 5b/5e point at a stale `.claude/skills/...` path.
   - `security-issue-fix` `tracker-update.md` cites an AGENTS.md section ("Release branches currently in flight") that no longer exists, and hardcodes release numbers.
   - Several skills write scratch files to a literal `/tmp/` path.
   
   ## Stack
   
   1. drop Snapshot drift
   2. **this PR**: split into siblings
   3. one safe-create recipe, board-recipe pointers
   4. trim the `security-model-*` always-on descriptions
   
   Part of #1344.
   
   Generated-by: Claude Code (Opus 5.5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(security): split oversized security SKILL.md files into linked siblings [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1436:
URL: https://github.com/apache/magpie/pull/1436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org