You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2024/09/22 08:42:36 UTC
[PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
reswqa opened a new pull request, #25374:
URL: https://github.com/apache/flink/pull/25374
## What is the purpose of the change
*Remove deprecated API in flink-streaming-java module*
## Brief change log
- *Remove deprecated API in flink-streaming-java module*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25374:
URL: https://github.com/apache/flink/pull/25374#issuecomment-2366135001
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "530bf52976a08ad3b847e6c1edd2b0304e329090",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "530bf52976a08ad3b847e6c1edd2b0304e329090",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 530bf52976a08ad3b847e6c1edd2b0304e329090 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #25374:
URL: https://github.com/apache/flink/pull/25374#discussion_r1772465481
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SourceNAryInputChainingITCase.java:
##########
@@ -365,7 +365,13 @@ private static JobGraph sinkAndCompileJobGraph(DataStream<?> stream) {
return StreamingJobGraphGenerator.createJobGraph(streamGraph);
}
- private static void verifySequence(final List<Long> sequence, final long from, final long to) {
+ private static void verifySequence(
+ final CloseableIterator<Long> iter, final long from, final long to) {
+ List<Long> sequence = new ArrayList<>();
Review Comment:
Yep, good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #25374:
URL: https://github.com/apache/flink/pull/25374#discussion_r1772464407
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/IntervalJoinITCase.java:
##########
@@ -361,6 +362,7 @@ public void testBoundsAreInclusiveByDefault() throws Exception {
DataStream<Tuple2<String, Integer>> streamOne =
env.fromData(Tuple2.of("key", 0), Tuple2.of("key", 1), Tuple2.of("key", 2))
+ .assignTimestampsAndWatermarks(WatermarkStrategy.forMonotonousTimestamps())
Review Comment:
I believe only the second one is needed(The first one is for debugging forget to delete...).
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/IntervalJoinITCase.java:
##########
@@ -361,6 +362,7 @@ public void testBoundsAreInclusiveByDefault() throws Exception {
DataStream<Tuple2<String, Integer>> streamOne =
env.fromData(Tuple2.of("key", 0), Tuple2.of("key", 1), Tuple2.of("key", 2))
+ .assignTimestampsAndWatermarks(WatermarkStrategy.forMonotonousTimestamps())
Review Comment:
I believe only the second one is needed(The first one is for debugging but forget to delete...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #25374:
URL: https://github.com/apache/flink/pull/25374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #25374:
URL: https://github.com/apache/flink/pull/25374#discussion_r1772461835
##########
flink-table/flink-sql-gateway/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
Review Comment:
Should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "codenohup (via GitHub)" <gi...@apache.org>.
codenohup commented on code in PR #25374:
URL: https://github.com/apache/flink/pull/25374#discussion_r1771593354
##########
flink-table/flink-sql-gateway/src/test/resources/log4j2-test.properties:
##########
@@ -18,7 +18,7 @@
# Set root logger level to OFF to not flood build logs
# set manually to INFO for debugging purposes
-rootLogger.level = OFF
+rootLogger.level = INFO
Review Comment:
why?
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SourceNAryInputChainingITCase.java:
##########
@@ -365,7 +365,13 @@ private static JobGraph sinkAndCompileJobGraph(DataStream<?> stream) {
return StreamingJobGraphGenerator.createJobGraph(streamGraph);
}
- private static void verifySequence(final List<Long> sequence, final long from, final long to) {
+ private static void verifySequence(
+ final CloseableIterator<Long> iter, final long from, final long to) {
+ List<Long> sequence = new ArrayList<>();
Review Comment:
It cloud use `org.apache.flink.util.CollectionUtil#iteratorToList`
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/IntervalJoinITCase.java:
##########
@@ -361,6 +362,7 @@ public void testBoundsAreInclusiveByDefault() throws Exception {
DataStream<Tuple2<String, Integer>> streamOne =
env.fromData(Tuple2.of("key", 0), Tuple2.of("key", 1), Tuple2.of("key", 2))
+ .assignTimestampsAndWatermarks(WatermarkStrategy.forMonotonousTimestamps())
Review Comment:
Why are there two _assignTimestampsAndWatermarks_ calls? The fist call may lack a _TimestampAssigner_, while the second call could potentially override the _WatermarkStrategy_ setted by the first.
##########
flink-table/flink-sql-gateway/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
Review Comment:
why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #25374:
URL: https://github.com/apache/flink/pull/25374#issuecomment-2369969287
@codenohup Thanks for the careful review! I have updated this PR, PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "codenohup (via GitHub)" <gi...@apache.org>.
codenohup commented on PR #25374:
URL: https://github.com/apache/flink/pull/25374#issuecomment-2368584275
LGTM overall, I have left some comments, cloud you have a look? @reswqa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36346][API] Remove deprecated API in flink-streaming-java module [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #25374:
URL: https://github.com/apache/flink/pull/25374#discussion_r1772461710
##########
flink-table/flink-sql-gateway/src/test/resources/log4j2-test.properties:
##########
@@ -18,7 +18,7 @@
# Set root logger level to OFF to not flood build logs
# set manually to INFO for debugging purposes
-rootLogger.level = OFF
+rootLogger.level = INFO
Review Comment:
Oops, unrelated change using for debug purpose. Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org