You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/19 09:41:12 UTC

[GitHub] [airflow] dstandish opened a new pull request #13183: fix parenthesis preventing keda ScaledObject creation

dstandish opened a new pull request #13183:
URL: https://github.com/apache/airflow/pull/13183


   fix placement of parentheses in keda autoscaler template so that keda scaledobject is created when enabled
   
   adds simple test to verify that keda object is created under right circumstances (though not all permutations covered)
   
   to do so, had to make schema validation optional
   
   closes: https://github.com/helm/helm/issues/6864


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dstandish edited a comment on pull request #13183: fix parenthesis preventing keda ScaledObject creation

Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on pull request #13183:
URL: https://github.com/apache/airflow/pull/13183#issuecomment-748568964


   @mik-laj thanks for taking a look
   
   i realized i forgot to include the tests I added! (just pushed)
   
   previously there were no tests related to keda (which is how this bug was able to stay hidden)
   
   so with this change at least we have a test that would have caught this error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dstandish commented on pull request #13183: fix parenthesis preventing keda ScaledObject creation

Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13183:
URL: https://github.com/apache/airflow/pull/13183#issuecomment-748568964


   @mik-laj thanks for taking a look
   
   i realized i forgot to include the tests I added!
   
   previously there were no tests related to keda (which is how this bug was able to stay hidden)
   
   so with this change at least we have a test that would have caught this error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #13183: fix parenthesis preventing keda ScaledObject creation

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13183:
URL: https://github.com/apache/airflow/pull/13183


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dstandish edited a comment on pull request #13183: fix parenthesis preventing keda ScaledObject creation

Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on pull request #13183:
URL: https://github.com/apache/airflow/pull/13183#issuecomment-748568964


   @mik-laj thanks for taking a look
   
   i realized i had forgotten to commit the tests I added! (just pushed)
   
   previously there were no tests related to keda (which is how this bug was able to stay hidden)
   
   so with this change at least we have a test that would have caught this error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dstandish edited a comment on pull request #13183: fix parenthesis preventing keda ScaledObject creation

Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on pull request #13183:
URL: https://github.com/apache/airflow/pull/13183#issuecomment-748568964


   @mik-laj thanks for taking a look
   
   i realized i had forgotten to commit the tests I added! (just pushed)
   
   previously there were no tests related to keda (which is how this bug was able to stay hidden)
   
   so with this change at least we test the "should we create keda objects" condition.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #13183: fix parenthesis preventing keda ScaledObject creation

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13183:
URL: https://github.com/apache/airflow/pull/13183#issuecomment-748549890


   > to do so, had to make schema validation optional cus the existing validator could not find schema. maybe this is cus it's a custom resource def? @dimberman maybe you know?
   
   Disabling schema validation only for a few exceptional cases, I think is a good solution. We will have to be more careful in our reviews, but if it's not frequent, that's not a problem.
   
   If this is a problem then we will have to implement support for CRDs that have JSON Schema specifications, but this is an extra effort. We can do it later if needed.
   https://github.com/kedacore/keda/blob/main/config/crd/bases/keda.sh_scaledobjects.yaml


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org