[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10910: [Fix-10909] Returns executionStatus for each process instance status.

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #10910:
URL: https://github.com/apache/dolphinscheduler/pull/10910#discussion_r919617148


##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppMessage.java:
##########
@@ -29,8 +29,8 @@ public class WechatAppMessage {
     private Map<String, String> text;
     private Map<String, String> markdown;
     private Integer safe;
-    private Integer enable_id_trans;
-    private Integer enable_duplicate_check;
+    private Integer enableIdTrans;

Review Comment:
   https://github.com/apache/dolphinscheduler/blob/2397423eb6893458cd13866dd16b2c2e92dda437/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatSender.java#L217-L218
   
   I think this may cause wechat send message error. We should avoid serializing these parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org