You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/14 07:04:40 UTC
[GitHub] [skywalking] naah69 opened a new issue #5311: rocketmq plugin of agent throw NullPointException
naah69 opened a new issue #5311:
URL: https://github.com/apache/skywalking/issues/5311
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
why it throwed exception and what i will do can make it work.
___
### Bug
- Which version of SkyWalking, OS and JRE?
agent 8.10 , openjdk 8 ,rocketmq4.3
- Which company or project?
- What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
i use sync send message in rocketmq,
it throw error and agent did't work ,don't send data to collector
```
ERROR 2020-08-14 14:47:48:750 AsyncSenderExecutor_1 InstMethodsInter : class[class org.apache.rocketmq.client.trace.AsyncTraceDispatcher$AsyncAppenderRequest$1] before method[onException] intercept failure
java.lang.NullPointerException
at org.apache.skywalking.apm.plugin.rocketMQ.v4.OnExceptionInterceptor.beforeMethod(OnExceptionInterceptor.java:42)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
at org.apache.rocketmq.client.trace.AsyncTraceDispatcher$AsyncAppenderRequest$1.onException(AsyncTraceDispatcher.java)
at org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl$4.run(DefaultMQProducerImpl.java:512)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-675886748
please assign me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683254374
Hi @wu-sheng， I went deep into the source code of RocketMQ, I think there is no need to add new plugin logic.
this issue is caused by wrong client and server version match. the exception is explained belows:
For the version newer than 4.3, RocketMQ added new AsyncTraceDispatcher class which collect metrics and send to broker. when use old server, it will not found the special topic in broker, then it throws a exception.
I think it will be ok for the plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683223807
hi @naah69 the bug is in the agent enhance logic. I need more time to check the logic of why intercept the interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683255247
> when use old server, it will not found the special topic in broker, then it throws a exception.
A little confused. I was thinking, this error only happens in the plugin codes, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683365982
this bug is also same with #3848 , please close it as duplicate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683259091
Sure, It is not easy to implement this, I perfer we can talk in qq.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5311:
URL: https://github.com/apache/skywalking/issues/5311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683256028
```
at org.apache.skywalking.apm.plugin.rocketMQ.v4.OnExceptionInterceptor.beforeMethod(OnExceptionInterceptor.java:42)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
at org.apache.rocketmq.client.trace.AsyncTraceDispatcher$AsyncAppenderRequest$1.onException(AsyncTraceDispatcher.java)
```
This is an `onException`, so, the `topicId` could be unavailable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683258036
Yes, no problem, I am new to RocketMQ too, the flow is like this
step1 : producer -> send user data -> broker
====
step2: AsyncTraceDispatcher collect metric -> async send to broker
The error was happened in step2, actually it is not affect the normal logic, just in the collect metric stage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui edited a comment on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui edited a comment on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683297613
after talked with wu-sheng, the solution is to compatible with this scenario, when the enhanceInfo is null, just create a local span with default topic name "no-topic"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683258993
This exception stack shows the LOC is this `at org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl$4.run(DefaultMQProducerImpl.java:512)`, which is a sending message exception,
https://github.com/apache/rocketmq/blob/master/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java#L512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-673969889
I recommend you debug locally, and check what is going on. No plugin test about RocketMQ plugin yet. If could build one by following plugin development doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683224634
Yes, the plugin of rocketMQ 4.x only test on version 4.1 , @naah69 rocketMQ used version 4.6 client, in version4.6 the interface of SendCallback has multi implement, which caused the problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683226564
> Got it, when you try to provide new plugin implement for 4.6(or any version newer), remember to add `witness` class for the previous versions, and make our plugins supporting all of them.
Yes, got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683256481
Perhaps I can change the OnExceptionInterceptor logic, and ignore this null topic case, what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683257097
This field is set by MessageSendInterceptor beforeMethod, which enhance class org.apache.rocketmq.client.impl.MQClientAPIImpl,
like I said before, it was not called the MQClientAPIImpl.sendMessage and direct go to exception logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683223950
> I need more time to check the logic of why intercept the interface
How does this happen? Does rocketMQ change the codebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683297613
after talk with wu-sheng, the solution is to compatible with this scenario, when the enhanceInfo is null, just create a local span with default topic name "no-topic"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683257989
If `MQClientAPIImpl` isn't executed, why? Is there another API for MQ client?
Here is the principle.
If the user codes are really accessing RocketMQ server, then, we should track them, even some APIs are not available. If we can't do this in some cases, then, this is a plugin bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui edited a comment on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui edited a comment on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683254374
Hi @wu-sheng， I went deep into the source code of RocketMQ, I think there is no need to add new plugin logic.
this issue is caused by wrong client and server version match. the exception happened as belows:
For the version newer than 4.3, RocketMQ added new AsyncTraceDispatcher class which collect metrics and send to broker. when use old server, it will not found the special topic in broker, then it throws a exception.
I think it will be ok for the plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] naah69 commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
naah69 commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-676970324
sure, i guess that the error was caused by `syncSend` ，there is no asyncSend in my application.but the error was throw by `org.apache.rocketmq.client.trace.AsyncTraceDispatcher$AsyncAppenderRequest`
i use Aliyun Distributed Tracing to monitor my application.
the application use [v8.1.0 of skywalking agent](https://www.apache.org/dyn/closer.cgi/skywalking/8.0.1/apache-skywalking-apm-8.0.1.tar.gz?spm=a2c4g.11186623.2.13.45b85968z5s9Z8&file=apache-skywalking-apm-8.0.1.tar.gz) to send info to Aliyun Distributed Tracing。
## myagent config:
```properties
agent.service_name=seedserver
agent.sample_n_per_3_secs=${SW_AGENT_SAMPLE:3}
collector.backend_service=xxxxxxx
agent.authentication=xxxxxxxxxxxxx
logging.file_name=${SW_LOGGING_FILE_NAME:skywalking-api.log}
logging.level=${SW_LOGGING_LEVEL:INFO}
```
## dependencies of spirngboot(jdk8):
```xml
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>2.3.0.RELEASE</version>
</parent>
```
## dependencies of myrocketmq:
```xml
<dependency>
<groupId>org.apache.rocketmq</groupId>
<artifactId>rocketmq-spring-boot-starter</artifactId>
<version>2.1.0</version>
<exclusions>
<exclusion>
<artifactId>commons-codec</artifactId>
<groupId>commons-codec</groupId>
</exclusion>
<exclusion>
<artifactId>commons-collections</artifactId>
<groupId>commons-collections</groupId>
</exclusion>
<exclusion>
<artifactId>commons-lang3</artifactId>
<groupId>org.apache.commons</groupId>
</exclusion>
<exclusion>
<artifactId>commons-logging</artifactId>
<groupId>commons-logging</groupId>
</exclusion>
<exclusion>
<artifactId>fastjson</artifactId>
<groupId>com.alibaba</groupId>
</exclusion>
</exclusions>
</dependency>
```
## part code of rocketmq:
### yaml config:
```
rocketmq:
name-server: http://xxxxxxx.cn-hangzhou.mq-internal.aliyuncs.com:8080
producer:
access-key: xxxxxxx
secret-key: xxxxxxx
group: GID_SEEDSERVER
consumer:
access-key: xxxxxxx
secret-key: xxxxxxx
```
### consumer：
```
@Slf4j
@Service
@RocketMQMessageListener(
topic = "SEEDSERVER_EXPORT",
consumerGroup = "GID_SEEDSERVER_EXPORT_" + "${spring.profiles.active}",
consumeTimeout = 24 * 60 * 60 * 1000,
selectorType = SelectorType.TAG,
selectorExpression = "${spring.profiles.active}"
)
```
### provider：
```
@Autowired
private RocketMQTemplate rocketMQTemplate;
@Value("${spring.profiles.active}")
private String profiles;
//sync send
rocketMQTemplate.syncSend("SEEDSERVER_EXPORT:" + profiles, JSON.toJSONString(message));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683259567
> Sure, It is not easy to implement this, I perfer we can talk in qq.
You could DM me, but after the discussion, you have to write the conclusion back here for all others to track.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683258659
OK. Got your point, so there are 2 message sending.
From my understanding, this should be traced ideally. If you want to give a try because this actually is an RPC. Of course, you also could skip in this case, but this could hide some bugs in the future. Because my guess, you will skip the logic if `enhanceInfo == null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-676914112
Hi @naah69 can you provide more detail about this bug? how to reproduce this bug (code) ? thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] naah69 commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
naah69 commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683629429
> Hi @naah69, For your case the quick fix is downgrade the client version ,
> since your rocketMQ server version is 4.3, you can downgrade the rocketmq-spring-boot-starter version from 2.1.0 to 2.0.1, I test is in my local env. it is ok. you can try and let me know
OMG.maybe i just can wait for 8.2.0 agent,becaust i use new feature `consumeTimeout` in annotation of rocketmq-spring-boot-starter-2.1.0.
it is not support in rocketmq-spring-boot-starter-2.0.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683256143
> ```
> at org.apache.skywalking.apm.plugin.rocketMQ.v4.OnExceptionInterceptor.beforeMethod(OnExceptionInterceptor.java:42)
> at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
> at org.apache.rocketmq.client.trace.AsyncTraceDispatcher$AsyncAppenderRequest$1.onException(AsyncTraceDispatcher.java)
> ```
>
> This is an `onException`, so, the `topicId` could be unavailable?
Yes, Old server can't have this topic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683366691
Linked, it will close when the PR merged. You could use the keyword, resolve, in the PR next time. Then GitHub will do this automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683226363
Hi @naah69, For your case the quick fix is downgrade the client version ,
since your rocketMQ server version is 4.3, you can downgrade the rocketmq-spring-boot-starter version from 2.1.0 to 2.0.1, I test is in my local env. it is ok. you can try and let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683256970
My point is, we are not reading the topic from RocketMQ API, it was set somewhere else. And the `SendCallBackEnhanceInfo` missing usually means we missed to intercept an important entrance of codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683256531
Please correct me if I am wrong.
From my code reading(not debug), this issue should be caused by `SendCallBackEnhanceInfo enhanceInfo = (SendCallBackEnhanceInfo) objInst.getSkyWalkingDynamicField();`, which can't have the this field.
Could you check, why this field isn't set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-677188490
thanks, will check later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] naah69 commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
naah69 commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683626186
> Hi @naah69, For your case the quick fix is downgrade the client version ,
> since your rocketMQ server version is 4.3, you can downgrade the rocketmq-spring-boot-starter version from 2.1.0 to 2.0.1, I test is in my local env. it is ok. you can try and let me know
3q,i will try it y
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683258425
You can check in https://hub.fastgit.org/apache/rocketmq/blob/master/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java#L558
It is not go to the send logic just go to L685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683368647
Ok, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683256070
Yes, It only happens in the plugin, This is because before the RocketMQ client send the metric data, it will check exist of the specified topic. for this case, the check is failed, and direct go to the OnException logic, which caused the Nullpointer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683631536
To fix the NullPointer, You can also upgrade your server version greater than 4.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683224823
Got it, when you try to provide new plugin implement for 4.6(or any version newer), remember to add `witness` class for the previous versions, and make our plugins supporting all of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] naah69 edited a comment on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
naah69 edited a comment on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-676970324
sure, i guess that the error was caused by `syncSend` ，there is no asyncSend in my application.but the error was throw by `org.apache.rocketmq.client.trace.AsyncTraceDispatcher$AsyncAppenderRequest`
i use Aliyun Distributed Tracing to monitor my application.
the application use [v8.1.0 of skywalking agent](https://www.apache.org/dyn/closer.cgi/skywalking/8.0.1/apache-skywalking-apm-8.0.1.tar.gz?spm=a2c4g.11186623.2.13.45b85968z5s9Z8&file=apache-skywalking-apm-8.0.1.tar.gz) to send info to Aliyun Distributed Tracing。
## myagent config:
```properties
agent.service_name=seedserver
agent.sample_n_per_3_secs=${SW_AGENT_SAMPLE:3}
collector.backend_service=xxxxxxx
agent.authentication=xxxxxxxxxxxxx
logging.file_name=${SW_LOGGING_FILE_NAME:skywalking-api.log}
logging.level=${SW_LOGGING_LEVEL:INFO}
```
## dependencies of spirngboot(jdk8):
```xml
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>2.3.0.RELEASE</version>
</parent>
```
## dependencies of myrocketmq:
```xml
<dependency>
<groupId>org.apache.rocketmq</groupId>
<artifactId>rocketmq-spring-boot-starter</artifactId>
<version>2.1.0</version>
<exclusions>
<exclusion>
<artifactId>commons-codec</artifactId>
<groupId>commons-codec</groupId>
</exclusion>
<exclusion>
<artifactId>commons-collections</artifactId>
<groupId>commons-collections</groupId>
</exclusion>
<exclusion>
<artifactId>commons-lang3</artifactId>
<groupId>org.apache.commons</groupId>
</exclusion>
<exclusion>
<artifactId>commons-logging</artifactId>
<groupId>commons-logging</groupId>
</exclusion>
<exclusion>
<artifactId>fastjson</artifactId>
<groupId>com.alibaba</groupId>
</exclusion>
</exclusions>
</dependency>
```
## part code of rocketmq:
### yaml config:
```yaml
rocketmq:
name-server: http://xxxxxxx.cn-hangzhou.mq-internal.aliyuncs.com:8080
producer:
access-key: xxxxxxx
secret-key: xxxxxxx
group: GID_SEEDSERVER
consumer:
access-key: xxxxxxx
secret-key: xxxxxxx
```
### consumer：
```java
@Slf4j
@Service
@RocketMQMessageListener(
topic = "SEEDSERVER_EXPORT",
consumerGroup = "GID_SEEDSERVER_EXPORT_" + "${spring.profiles.active}",
consumeTimeout = 24 * 60 * 60 * 1000,
selectorType = SelectorType.TAG,
selectorExpression = "${spring.profiles.active}"
)
```
### provider：
```java
@Autowired
private RocketMQTemplate rocketMQTemplate;
@Value("${spring.profiles.active}")
private String profiles;
//sync send
rocketMQTemplate.syncSend("SEEDSERVER_EXPORT:" + profiles, JSON.toJSONString(message));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] naah69 commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
naah69 commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683699198
in production envirements, we use rocketmq of aliyun version,so i don't know which corresponding version of open source version ，i had submit work order to ask version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5311: rocketmq plugin of agent throw NullPointException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5311:
URL: https://github.com/apache/skywalking/issues/5311#issuecomment-683257420
Oh, you mean, the codes don't access the RocketMQ? It used to be causing error?
Sorry, I am not familiar with the RocketMQ thing. Just try to understand from your description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org