You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Michael Dürig <md...@apache.org> on 2016/02/05 10:17:53 UTC

Re: svn commit: r1728525 - /jackrabbit/oak/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/Compactor.java

On 4.2.16 7:17 , alexparvulescu@apache.org wrote:
> Author: alexparvulescu
> Date: Thu Feb  4 18:17:40 2016
> New Revision: 1728525
>
> URL: http://svn.apache.org/viewvc?rev=1728525&view=rev
> Log:
> OAK-3988 Offline compaction should avoid loading external binaries

>               long count = 0;

...

>                       count += size;
>                       if (size >= offlineThreshold || count >= offlineThreshold) {
>                           return true;
>
>

I think the if condition can be simplified to (count >= 
offlineThreshold) as count >= size would always hold.

Michael