You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/27 08:49:08 UTC

[GitHub] [incubator-shardingsphere] geomonlin opened a new pull request #4497: update example orchestration to 5.x

geomonlin opened a new pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497
 
 
   Fixes #4435 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-592002761
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=h1) Report
   > Merging [#4497](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6af76821856271d81cb88e086b1b20ec1c2355d0?src=pr&el=desc) will **decrease** coverage by `0.61%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4497      +/-   ##
   ============================================
   - Coverage     55.23%   54.61%   -0.62%     
   - Complexity      330      331       +1     
   ============================================
     Files           953      970      +17     
     Lines         18026    18120      +94     
     Branches       3408     3451      +43     
   ============================================
   - Hits           9956     9896      -60     
   - Misses         7425     7587     +162     
   + Partials        645      637       -8
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ql/parser/relation/SQLStatementContextFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL1NRTFN0YXRlbWVudENvbnRleHRGYWN0b3J5LmphdmE=) | `12.24% <0%> (-87.76%)` | `0% <0%> (ø)` | |
   | [.../sql/parser/sql/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnQuamF2YQ==) | `4.34% <0%> (-24.23%)` | `0% <0%> (ø)` | |
   | [...ct/projection/engine/ProjectionsContextEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vZW5naW5lL1Byb2plY3Rpb25zQ29udGV4dEVuZ2luZS5qYXZh) | `61.11% <0%> (-8.89%)` | `0% <0%> (ø)` | |
   | [...l/parser/relation/segment/table/TablesContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvdGFibGUvVGFibGVzQ29udGV4dC5qYXZh) | `86.53% <0%> (-2.7%)` | `0% <0%> (ø)` | |
   | [.../sql/parser/sql/statement/dml/InsertStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9JbnNlcnRTdGF0ZW1lbnQuamF2YQ==) | `88.88% <0%> (-2.54%)` | `0% <0%> (ø)` | |
   | [...generator/impl/InsertCipherNameTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvSW5zZXJ0Q2lwaGVyTmFtZVRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <0%> (ø)` | `1% <0%> (ø)` | :arrow_down: |
   | [...tement/dal/dialect/mysql/ShowColumnsStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RhbC9kaWFsZWN0L215c3FsL1Nob3dDb2x1bW5zU3RhdGVtZW50LmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...nerator/impl/ShadowInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvU2hhZG93SW5zZXJ0VmFsdWVzVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...keygen/GeneratedKeyInsertColumnTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwva2V5Z2VuL0dlbmVyYXRlZEtleUluc2VydENvbHVtblRva2VuR2VuZXJhdG9yLmphdmE=) | `100% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...ardingjdbc/executor/AbstractStatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9BYnN0cmFjdFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `41.66% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [77 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=footer). Last update [6af7682...eb54d3b](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r385472627
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/resources/META-INF/zookeeper/cloud/encrypt.yaml
 ##########
 @@ -1,7 +1,8 @@
 orchestration:
-  name: demo_yaml_ds_encrypt
-  overwrite: false
-  registry:
-    type: zookeeper
+  demo_yaml_ds_encrypt:
+    orchestrationType: config_center,registry_center
+    instanceType: zookeeper
     serverLists: localhost:2181
     namespace: orchestration-yaml-demo
+    props:
+      overwrite: true
 
 Review comment:
   There should be a blank line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-592002761
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=h1) Report
   > Merging [#4497](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6af76821856271d81cb88e086b1b20ec1c2355d0?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4497   +/-   ##
   =========================================
     Coverage     55.23%   55.23%           
     Complexity      330      330           
   =========================================
     Files           953      953           
     Lines         18026    18026           
     Branches       3408     3408           
   =========================================
     Hits           9956     9956           
     Misses         7425     7425           
     Partials        645      645
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=footer). Last update [6af7682...3318217](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-591885129
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=h1) Report
   > Merging [#4497](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/251d1286cb0d5da0af8ddc3f0c51d21abc4ec2f1?src=pr&el=desc) will **increase** coverage by `0.22%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4497      +/-   ##
   ============================================
   + Coverage        55%   55.23%   +0.22%     
   + Complexity      332      330       -2     
   ============================================
     Files           958      953       -5     
     Lines         18478    18027     -451     
     Branches       3417     3408       -9     
   ============================================
   - Hits          10164     9957     -207     
   + Misses         7655     7425     -230     
   + Partials        659      645      -14
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...er/sql/statement/generic/AbstractSQLStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2dlbmVyaWMvQWJzdHJhY3RTUUxTdGF0ZW1lbnQuamF2YQ==) | `66.66% <0%> (-26.2%)` | `0% <0%> (-1%)` | |
   | [...here/orchestration/constant/OrchestrationType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY29uc3RhbnQvT3JjaGVzdHJhdGlvblR5cGUuamF2YQ==) | `42.85% <0%> (-7.15%)` | `0% <0%> (ø)` | |
   | [...tion/center/instance/CuratorZookeeperInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckluc3RhbmNlLmphdmE=) | `38.13% <0%> (-2.67%)` | `0% <0%> (ø)` | |
   | [...internal/registry/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvU2hhcmRpbmdPcmNoZXN0cmF0aW9uRmFjYWRlLmphdmE=) | `83.67% <0%> (-1.44%)` | `0% <0%> (ø)` | |
   | [...here/sql/parser/visitor/impl/OracleDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvT3JhY2xlRENMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [.../sql/parser/visitor/impl/PostgreSQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxEQUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...e/sql/parser/visitor/impl/SQLServerDCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU1FMU2VydmVyRENMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...phere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERBTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...phere/sql/parser/visitor/impl/SQL92DDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRETFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...here/sql/parser/visitor/impl/OracleDDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvT3JhY2xlRERMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [34 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=footer). Last update [251d128...69c68e6](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-592002761
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=h1) Report
   > Merging [#4497](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6af76821856271d81cb88e086b1b20ec1c2355d0?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4497   +/-   ##
   =========================================
     Coverage     55.23%   55.23%           
     Complexity      330      330           
   =========================================
     Files           953      953           
     Lines         18026    18026           
     Branches       3408     3408           
   =========================================
     Hits           9956     9956           
     Misses         7425     7425           
     Partials        645      645
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=footer). Last update [6af7682...c300134](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] geomonlin commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
geomonlin commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r386069556
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/resources/META-INF/nacos/cloud/encrypt.yaml
 ##########
 @@ -1,10 +1,18 @@
 orchestration:
-  name: demo_yaml_ds_encrypt
-  overwrite: false
-  registry:
-    type: nacos
+  demo_naocs_yaml_ds_encrypt:
+    orchestrationType: config_center
+    instanceType: nacos
     serverLists: localhost:8848
-    namespace:
+    namespace: orchestration-yaml-demo
 
 Review comment:
   yeah You're right. thx

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-591888992
 
 
   ## Pull Request Test Coverage Report for [Build 9822](https://coveralls.io/builds/28994121)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **58.878%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28994121/badge)](https://coveralls.io/builds/28994121) |
   | :-- | --: |
   | Change from base [Build 9820](https://coveralls.io/builds/28989668): |  0.0% |
   | Covered Lines: | 10614 |
   | Relevant Lines: | 18027 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r385473739
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-spring-boot-example/src/main/resources/application-local-nacos-sharding-databases-tables.properties
 ##########
 @@ -35,8 +35,15 @@ spring.shardingsphere.sharding.tables.t_order_item.key-generator.column=order_it
 spring.shardingsphere.sharding.tables.t_order_item.key-generator.type=SNOWFLAKE
 spring.shardingsphere.sharding.tables.t_order_item.key-generator.props.worker.id=123
 
-spring.shardingsphere.orchestration.name=demo_spring_boot_ds_sharding
-spring.shardingsphere.orchestration.overwrite=true
-spring.shardingsphere.orchestration.registry.type=nacos
-spring.shardingsphere.orchestration.registry.server-lists=localhost:8848
-spring.shardingsphere.orchestration.registry.namespace=
+spring.shardingsphere.orchestration.demo_spring_boot_ds_sharding.orchestration-type=config_center
+spring.shardingsphere.orchestration.demo_spring_boot_ds_sharding.instance-type=nacos
+spring.shardingsphere.orchestration.demo_spring_boot_ds_sharding.server-lists=localhost:8848
+spring.shardingsphere.orchestration.demo_spring_boot_ds_sharding.namespace=
+spring.shardingsphere.orchestration.demo_spring_boot_ds_sharding.props.overwrite=true
+
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_sharding.orchestration-type=registry_center
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_sharding.instance-type=zookeeper
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_sharding.server-lists=localhost:2181
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_sharding.namespace=orchestration-spring-boot-demo
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_sharding.props.overwrite=true
+
 
 Review comment:
   There are redundant blank line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r385475109
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-spring-namespace-example/src/main/resources/META-INF/zookeeper/local/application-encrypt.xml
 ##########
 @@ -59,15 +59,15 @@
             </encrypt:tables>
             <encrypt:encryptors>
                 <encrypt:encryptor id="name_encryptor" type="AES" props-ref="props"/>
-                <encrypt:encryptor id="pwd_encryptor" type="assistedTest" />
 
 Review comment:
   Why fix this type param?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] geomonlin commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
geomonlin commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r386069509
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/resources/META-INF/nacos/local/encrypt.yaml
 ##########
 @@ -3,7 +3,7 @@ orchestration:
     orchestrationType: config_center
     instanceType: nacos
     serverLists: localhost:8848
-    namespace: orchestration-yaml-demo
 
 Review comment:
   This namespace  become namespaceId in naocs. If write namespace ,found should write  value of n**amespaceId "db5af0a7-ae65-49b2-810a-df5cb77103a1"**. However Show the configuration with empty namespace by default in nacos. 
   ![image](https://user-images.githubusercontent.com/26007894/75618004-5f4e0680-5ba2-11ea-9823-baf799772ef0.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r385471125
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/resources/META-INF/nacos/cloud/encrypt.yaml
 ##########
 @@ -1,10 +1,18 @@
 orchestration:
-  name: demo_yaml_ds_encrypt
-  overwrite: false
-  registry:
-    type: nacos
+  demo_naocs_yaml_ds_encrypt:
+    orchestrationType: config_center
+    instanceType: nacos
     serverLists: localhost:8848
-    namespace:
+    namespace: orchestration-yaml-demo
 
 Review comment:
   I understand nacos's namespace is namespace's id, not namespace's name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-592002761
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=h1) Report
   > Merging [#4497](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6af76821856271d81cb88e086b1b20ec1c2355d0?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4497   +/-   ##
   =========================================
     Coverage     55.23%   55.23%           
     Complexity      330      330           
   =========================================
     Files           953      953           
     Lines         18026    18026           
     Branches       3408     3408           
   =========================================
     Hits           9956     9956           
     Misses         7425     7425           
     Partials        645      645
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=footer). Last update [6af7682...3318217](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] geomonlin commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
geomonlin commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r386076259
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/java/org/apache/shardingsphere/example/orchestration/raw/jdbc/config/RegistryCenterConfigurationUtil.java
 ##########
 @@ -31,20 +34,58 @@
 
     private static final String NACOS_NAMESPACE = "";
     
-    public static RegistryCenterConfiguration getZooKeeperConfiguration() {
-        RegistryCenterConfiguration result = new RegistryCenterConfiguration("zookeeper");
+    public static Map<String, InstanceConfiguration> getZooKeeperConfiguration(String overwrite, ShardingType shardingType) {
+        Map<String, InstanceConfiguration> instanceConfigurationMap = new HashMap<String, InstanceConfiguration>();
+        Properties properties = new Properties();
+        properties.setProperty("overwrite", overwrite);
+        InstanceConfiguration result = new InstanceConfiguration("zookeeper", properties);
         result.setServerLists(ZOOKEEPER_CONNECTION_STRING);
         result.setNamespace(NAMESPACE);
-        return result;
+        result.setOrchestrationType("registry_center,config_center");
+        switch (shardingType) {
+            case SHARDING_DATABASES_AND_TABLES:
 
 Review comment:
   Diff dataSource name persist to different dataId.  As shown in the picture：
   ![image](https://user-images.githubusercontent.com/26007894/75619596-21a8a800-5bb9-11ea-9b9d-2c124d0954c8.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r386037835
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-spring-namespace-example/src/main/resources/META-INF/zookeeper/local/application-master-slave.xml
 ##########
 @@ -15,44 +15,44 @@
                         http://shardingsphere.apache.org/schema/shardingsphere/masterslave/master-slave.xsd
                         http://shardingsphere.apache.org/schema/shardingsphere/orchestration
                         http://shardingsphere.apache.org/schema/shardingsphere/orchestration/orchestration.xsd">
-    <import resource="classpath*:META-INF/zookeeper/registry-center.xml" />
-    <context:component-scan base-package="org.apache.shardingsphere.example.core.mybatis" />
+    <import resource="classpath*:META-INF/zookeeper/registry-center.xml"/>
+    <context:component-scan base-package="org.apache.shardingsphere.example.core.mybatis"/>
 
     <bean id="demo_ds_master" class="com.zaxxer.hikari.HikariDataSource" destroy-method="close">
         <property name="driverClassName" value="com.mysql.jdbc.Driver"/>
         <property name="jdbcUrl" value="jdbc:mysql://localhost:3306/demo_ds_master"/>
         <property name="username" value="root"/>
         <property name="password" value=""/>
     </bean>
-    
+
     <bean id="demo_ds_slave_0" class="com.zaxxer.hikari.HikariDataSource" destroy-method="close">
         <property name="driverClassName" value="com.mysql.jdbc.Driver"/>
         <property name="jdbcUrl" value="jdbc:mysql://localhost:3306/demo_ds_slave_0"/>
         <property name="username" value="root"/>
         <property name="password" value=""/>
     </bean>
-    
+
     <bean id="demo_ds_slave_1" class="com.zaxxer.hikari.HikariDataSource" destroy-method="close">
         <property name="driverClassName" value="com.mysql.jdbc.Driver"/>
         <property name="jdbcUrl" value="jdbc:mysql://localhost:3306/demo_ds_slave_1"/>
         <property name="username" value="root"/>
         <property name="password" value=""/>
     </bean>
 
-    <master-slave:load-balance-algorithm id="randomStrategy" type="RANDOM" />
 
 Review comment:
   the last blank is standard.
   should be retrieved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r385473255
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-spring-boot-example/src/main/resources/application-local-nacos-master-slave.properties
 ##########
 @@ -23,8 +23,14 @@ spring.shardingsphere.masterslave.name=ds_ms
 spring.shardingsphere.masterslave.master-data-source-name=ds_master
 spring.shardingsphere.masterslave.slave-data-source-names=ds_slave_0,ds_slave_1
 
-spring.shardingsphere.orchestration.name=demo_spring_boot_ds_ms
-spring.shardingsphere.orchestration.overwrite=true
-spring.shardingsphere.orchestration.registry.type=nacos
-spring.shardingsphere.orchestration.registry.server-lists=localhost:8848
-spring.shardingsphere.orchestration.registry.namespace=
+spring.shardingsphere.orchestration.demo_spring_boot_ds_ms.orchestration-type=config_center
+spring.shardingsphere.orchestration.demo_spring_boot_ds_ms.instance-type=nacos
+spring.shardingsphere.orchestration.demo_spring_boot_ds_ms.server-lists=localhost:8848
+spring.shardingsphere.orchestration.demo_spring_boot_ds_ms.namespace=
+spring.shardingsphere.orchestration.demo_spring_boot_ds_ms.props.overwrite=true
+
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_ms.orchestration-type=registry_center
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_ms.instance-type=zookeeper
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_ms.server-lists=localhost:2181
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_ms.namespace=orchestration-spring-boot-demo
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_ms.props.overwrite=true
 
 Review comment:
   The same to above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r385471504
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/resources/META-INF/nacos/local/encrypt.yaml
 ##########
 @@ -1,13 +1,21 @@
 orchestration:
-  name: demo_yaml_ds_encrypt
-  overwrite: true
-  registry:
-    type: nacos
+  demo_nacos_yaml_ds_encrypt:
+    orchestrationType: config_center
+    instanceType: nacos
     serverLists: localhost:8848
-    namespace:
+    namespace: orchestration-yaml-demo
 
 Review comment:
   The same to above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r386036144
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/resources/META-INF/nacos/local/encrypt.yaml
 ##########
 @@ -3,7 +3,7 @@ orchestration:
     orchestrationType: config_center
     instanceType: nacos
     serverLists: localhost:8848
-    namespace: orchestration-yaml-demo
 
 Review comment:
   why remove namespace?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r386036813
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-raw-jdbc-example/src/main/java/org/apache/shardingsphere/example/orchestration/raw/jdbc/config/RegistryCenterConfigurationUtil.java
 ##########
 @@ -31,20 +34,58 @@
 
     private static final String NACOS_NAMESPACE = "";
     
-    public static RegistryCenterConfiguration getZooKeeperConfiguration() {
-        RegistryCenterConfiguration result = new RegistryCenterConfiguration("zookeeper");
+    public static Map<String, InstanceConfiguration> getZooKeeperConfiguration(String overwrite, ShardingType shardingType) {
+        Map<String, InstanceConfiguration> instanceConfigurationMap = new HashMap<String, InstanceConfiguration>();
+        Properties properties = new Properties();
+        properties.setProperty("overwrite", overwrite);
+        InstanceConfiguration result = new InstanceConfiguration("zookeeper", properties);
         result.setServerLists(ZOOKEEPER_CONNECTION_STRING);
         result.setNamespace(NAMESPACE);
-        return result;
+        result.setOrchestrationType("registry_center,config_center");
+        switch (shardingType) {
+            case SHARDING_DATABASES_AND_TABLES:
 
 Review comment:
   why add a shardingtype swtich?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#discussion_r385473149
 
 

 ##########
 File path: examples/sharding-jdbc-example/orchestration-example/orchestration-spring-boot-example/src/main/resources/application-local-nacos-encrypt.properties
 ##########
 @@ -31,8 +31,14 @@ spring.shardingsphere.encrypt.tables.t_order.columns.status.encryptor=status_enc
 spring.shardingsphere.props.query.with.cipher.comlum=true
 spring.shardingsphere.props.sql.show=true
 
-spring.shardingsphere.orchestration.name=demo_spring_boot_ds_encrypt
-spring.shardingsphere.orchestration.overwrite=true
-spring.shardingsphere.orchestration.registry.type=nacos
-spring.shardingsphere.orchestration.registry.server-lists=localhost:8848
-spring.shardingsphere.orchestration.registry.namespace=
+spring.shardingsphere.orchestration.demo_spring_boot_ds_encrypt.orchestration-type=config_center
+spring.shardingsphere.orchestration.demo_spring_boot_ds_encrypt.instance-type=nacos
+spring.shardingsphere.orchestration.demo_spring_boot_ds_encrypt.server-lists=localhost:8848
+spring.shardingsphere.orchestration.demo_spring_boot_ds_encrypt.namespace=
+spring.shardingsphere.orchestration.demo_spring_boot_ds_encrypt.props.overwrite=true
+
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_encrypt.orchestration-type=registry_center
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_encrypt.instance-type=zookeeper
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_encrypt.server-lists=localhost:2181
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_encrypt.namespace=orchestration-spring-boot-demo
+spring.shardingsphere.orchestration.demo1_spring_boot_ds_encrypt.props.overwrite=true
 
 Review comment:
   There should be a blank line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-593068197
 
 
   ![image](https://user-images.githubusercontent.com/807508/75621936-b91bf400-5bd5-11ea-9aee-c78fa38a89fa.png)
   
   ```
   examples\sharding-jdbc-example\orchestration-example\orchestration-raw-jdbc-example\src\main\java\org\apache\shardingsphere\example\orchestration\raw\jdbc\JavaConfigurationExampleMain.java
   examples\sharding-jdbc-example\orchestration-example\orchestration-raw-jdbc-example\src\main\java\org\apache\shardingsphere\example\orchestration\raw\jdbc\YamlConfigurationExampleMain.java
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4497: update example orchestration to 5.x

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4497: update example orchestration to 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/4497#issuecomment-592002761
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=h1) Report
   > Merging [#4497](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6af76821856271d81cb88e086b1b20ec1c2355d0?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4497      +/-   ##
   ============================================
   - Coverage     55.23%   55.17%   -0.06%     
   - Complexity      330      331       +1     
   ============================================
     Files           953      954       +1     
     Lines         18026    17960      -66     
     Branches       3408     3397      -11     
   ============================================
   - Hits           9956     9909      -47     
   + Misses         7425     7418       -7     
   + Partials        645      633      -12
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../sql/parser/sql/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnQuamF2YQ==) | `4.34% <0%> (-24.23%)` | `0% <0%> (ø)` | |
   | [...ct/projection/engine/ProjectionsContextEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vZW5naW5lL1Byb2plY3Rpb25zQ29udGV4dEVuZ2luZS5qYXZh) | `61.11% <0%> (-8.89%)` | `0% <0%> (ø)` | |
   | [...l/parser/relation/segment/table/TablesContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvdGFibGUvVGFibGVzQ29udGV4dC5qYXZh) | `85.91% <0%> (-3.32%)` | `0% <0%> (ø)` | |
   | [.../sql/parser/sql/statement/dml/InsertStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9JbnNlcnRTdGF0ZW1lbnQuamF2YQ==) | `88.88% <0%> (-2.54%)` | `0% <0%> (ø)` | |
   | [...tement/dal/dialect/mysql/ShowColumnsStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RhbC9kaWFsZWN0L215c3FsL1Nob3dDb2x1bW5zU3RhdGVtZW50LmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...nt/ddl/constraint/ConstraintDefinitionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kZGwvY29uc3RyYWludC9Db25zdHJhaW50RGVmaW5pdGlvblNlZ21lbnQuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...l/parser/sql/statement/ddl/DropTableStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RkbC9Ecm9wVGFibGVTdGF0ZW1lbnQuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [.../parser/sql/statement/ddl/AlterIndexStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RkbC9BbHRlckluZGV4U3RhdGVtZW50LmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...phere/sql/parser/visitor/impl/SQL92DDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRETFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...ql/parser/sql/statement/dcl/DenyUserStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RjbC9EZW55VXNlclN0YXRlbWVudC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [26 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=footer). Last update [6af7682...f991aa4](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services