You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2021/08/24 09:31:26 UTC

[Impala-ASF-CR] IMPALA-10822: Allow multiple group returns for LDAP Search

Tamas Mate has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17794 )

Change subject: IMPALA-10822: Allow multiple group returns for LDAP Search
......................................................................

IMPALA-10822: Allow multiple group returns for LDAP Search

This commit updates the LdapSearch method to allow multiple results.
LdapSearch method was written generally and used for both user and group
searches. While it is reasonable to fail authentication requests where
the LDAP Search returns more than one user this should not be the case
for group searches, as a user can be part of multiple groups matching
the search criteria.

This commit moves the logic that checks the number of results to the
specific user and group search methods.

Testing:
 - Updated the unit test to cover this use-case

Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e
---
M be/src/util/ldap-search-bind.cc
M be/src/util/ldap-simple-bind.cc
M be/src/util/ldap-util.cc
M be/src/util/ldap-util.h
M fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java
M fe/src/test/resources/users.ldif
6 files changed, 42 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/17794/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e
Gerrit-Change-Number: 17794
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>