You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2026/08/19 13:27:22 UTC
[PR] HDDS-16223. Remove racy pre-condition assertion in TestRefreshVolumeUsageHandler [ozone]
rich7420 opened a new pull request, #11063:
URL: https://github.com/apache/ozone/pull/11063
## What changes were proposed in this pull request?
The test sets HDDS_NODE_REPORT_INTERVAL to 1s, so the datanode node report can reach SCM between key.close() and the assertion that SCM still shows the pre-write used space, making assertTrue(...getScmUsed().isEqual(baseline)) intermittently fail (expected true but was false). That pre-condition asserts a transient not-yet-propagated state and adds no coverage; the intended behavior (SCM eventually reflects the increased used space) is already verified by the following waitFor and assertTrue(...isGreater(baseline)). Remove the racy assertion.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16223
## How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/32255956955/
https://github.com/rich7420/ozone/actions/runs/32255725038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16223. Remove racy pre-condition assertion in TestRefreshVolumeUsageHandler [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 merged PR #11063:
URL: https://github.com/apache/ozone/pull/11063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16223. Remove racy pre-condition assertion in TestRefreshVolumeUsageHandler [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #11063:
URL: https://github.com/apache/ozone/pull/11063#issuecomment-5386261307
@chihsuan and @chungen0126 thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org