You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/04/12 05:55:45 UTC

[GitHub] [storm] srdo commented on issue #2995: change Date.getTime() to System.currentTimeMillis()

srdo commented on issue #2995: change Date.getTime() to System.currentTimeMillis()
URL: https://github.com/apache/storm/pull/2995#issuecomment-482447517
 
 
   You are getting a checkstyle violation, which needs to be fixed. When you run `mvn install` in the `storm-hive` directory, you will get a `target/checkstyle-violation.xml` file. Please open that file and find the violation that was introduced by this change, then fix it.
   
   The change looks good. Consider using `Time.currentTimeMillis` instead, to integrate with Storm's time simulation. Also please rename the PR and commit message so it contains the JIRA issue number.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services