[GitHub] [spark] karenfeng commented on a change in pull request #32017: [SPARK-34923][SQL] Metadata output should be empty by default

[GitBox <gi...@apache.org>]

karenfeng commented on a change in pull request #32017:
URL: https://github.com/apache/spark/pull/32017#discussion_r605847308



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -924,11 +947,6 @@ case class SubqueryAlias(
     child.output.map(_.withQualifier(qualifierList))
   }
 
-  override def metadataOutput: Seq[Attribute] = {
-    val qualifierList = identifier.qualifier :+ alias
-    child.metadataOutput.map(_.withQualifier(qualifierList))
-  }

Review comment:
       @cloud-fan, should we support this case if it requires changing the query during analysis after being resolved?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org