You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/20 00:47:20 UTC

[GitHub] [arrow] vibhatha commented on pull request #14024: ARROW-17521: [Python] Add python bindings for NamedTableProvider for Substrait consumer

vibhatha commented on PR #14024:
URL: https://github.com/apache/arrow/pull/14024#issuecomment-1284745953

   > This is a nice improvement!
   > 
   > I am wondering one thing: why does the function take a list of names, instead of a single name?
   > 
   > I understand from [#14024 (comment)](https://github.com/apache/arrow/pull/14024#issuecomment-1236472120) that this is because the name can _potentially_ be a list of names indicating some nested schema.
   > 
   > But for the simple case of single names, having a function that just gets a string and returns a table would be simpler to implement. And for example that would allow to actually implement this easily with a mapping (eg `table_provide={"table1": table1, "table2: table2}.get`)
   > 
   > Would it be an option to call the function with a single string, in case of length 1 list?
   
   Good point. Probably we can create a Cython level wrapper for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org