[GitHub] [lucene-solr-operator] anshumg commented on a change in pull request #229: Resolve dependency license handling

[GitBox <gi...@apache.org>]

anshumg commented on a change in pull request #229:
URL: https://github.com/apache/lucene-solr-operator/pull/229#discussion_r590713737



##########
File path: NOTICE
##########
@@ -26,3 +26,12 @@ distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
+
+The Solr Operator project is built using Kubebuilder, which is Apache 2.0 licensed.
+    https://github.com/kubernetes-sigs/kubebuilder
+
+The reconcileStorageFinalizer login in
+    controllers/solrcloud_controller.go
+was influenced by the same logic in the Zookeeper Operator, which is Apache 2.0 licensed.
+    https://github.com/pravega/zookeeper-operator/blob/v0.2.9/pkg/controller/zookeepercluster/zookeepercluster_controller.go#L629)
+Copyright (c) 2020 Dell Inc., or its subsidiaries. All Rights Reserved.

Review comment:
       nit: missing newline

##########
File path: dependency_licenses.csv
##########
@@ -0,0 +1,53 @@
+cloud.google.com/go/compute/metadata,Unknown,Apache-2.0

Review comment:
       Do we need to store this file (in this format) ?

##########
File path: hack/install_dependencies.sh
##########
@@ -32,3 +32,6 @@ if !(which kubebuilder && (kubebuilder version | grep ${kubebuilder_version}));
 else
   echo "Kubebuilder already installed at $(which kubebuilder)"
 fi
+
+# Install go-licenses
+go get github.com/google/go-licenses

Review comment:
       nit: new line

##########
File path: .github/workflows/docker.yaml
##########
@@ -17,4 +17,4 @@ jobs:
 
       # Cleanup & Install dependencies
       - run: docker --version
-      - run: make docker-vendor-build
\ No newline at end of file
+      - run: make docker-build

Review comment:
       nit: new line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org