[jira] [Commented] (OPENMEETINGS-1636) Upgrade AppointmentManager from HttpClient 3.x to 4.x

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENMEETINGS-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671354#comment-16671354 ] 

ASF GitHub Bot commented on OPENMEETINGS-1636:
----------------------------------------------

solomax commented on a change in pull request #12: OPENMEETINGS-1636 Upgrade Caldav4j to 1.0.0-rc.1
URL: https://github.com/apache/openmeetings/pull/12#discussion_r229983809
 
 

 ##########
 File path: openmeetings-service/src/main/java/org/apache/openmeetings/service/calendar/caldav/IcalUtils.java
 ##########
 @@ -242,16 +249,23 @@ private Appointment addVEventPropertiestoAppointment(Appointment a, CalendarComp
 				URI uri = URI.create(attendee.getValue());
 				if ("mailto".equals(uri.getScheme())) {
 					String email = uri.getSchemeSpecificPart();
+
+					Role role = attendee.getParameter(Role.CHAIR.getName());
+					if(role != null && role.getValue().equals(Role.CHAIR.getValue())
 
 Review comment:
   Please add `{}` here
   so it would be
   ```
   if (...) {
       continue;
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Upgrade AppointmentManager from HttpClient 3.x to 4.x
> -----------------------------------------------------
>
>                 Key: OPENMEETINGS-1636
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1636
>             Project: Openmeetings
>          Issue Type: Improvement
>          Components: HTML5/Calendar
>            Reporter: Ankush Mishra
>            Assignee: Ankush Mishra
>            Priority: Minor
>             Fix For: 4.0.7
>
>
> I had been waiting for [JCR-2406|https://issues.apache.org/jira/browse/JCR-2406] to close. Since, that has been completed for a couple of months, I opened another Issue for CalDAV4j [here|https://github.com/caldav4j/caldav4j/issues/63] , which I will try to first release to the Central Repo soon, with 3.x, after which I will get to work on the migration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)