You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/28 02:58:26 UTC
[GitHub] [iotdb] JackieTien97 commented on a change in pull request #5360: Fix typos in mpp.thrift
JackieTien97 commented on a change in pull request #5360:
URL: https://github.com/apache/iotdb/pull/5360#discussion_r836021684
##########
File path: thrift/src/main/thrift/mpp.thrift
##########
@@ -82,16 +82,16 @@ struct TCancelFragmentInstanceReq {
struct TCancelResp {
1: required bool cancelled
- 2: optional string messsga
+ 2: optional string messsage
}
-struct ShcameFetchReqest {
+struct SchemeFetchRequest {
Review comment:
```suggestion
struct SchemaFetchRequest {
```
##########
File path: thrift/src/main/thrift/mpp.thrift
##########
@@ -105,11 +105,11 @@ service InternalService {
TCancelResp cancelFragmentInstance(TCancelFragmentInstanceReq req);
- ShcameFetchResponse fetchSchema(ShcameFetchReqest req)
+ SchemeFetchResponse fetchSchema(SchemeFetchRequest req)
Review comment:
```suggestion
SchemaFetchResponse fetchSchema(SchemaFetchRequest req)
```
##########
File path: server/src/main/java/org/apache/iotdb/db/service/InternalServiceImpl.java
##########
@@ -58,7 +67,7 @@ public TCancelResp cancelFragmentInstance(TCancelFragmentInstanceReq req) throws
}
@Override
- public ShcameFetchResponse fetchSchema(ShcameFetchReqest req) throws TException {
+ public SchemeFetchResponse fetchSchema(SchemeFetchRequest req) throws TException {
Review comment:
```suggestion
public SchemaFetchResponse fetchSchema(SchemaFetchRequest req) throws TException {
```
##########
File path: thrift/src/main/thrift/mpp.thrift
##########
@@ -82,16 +82,16 @@ struct TCancelFragmentInstanceReq {
struct TCancelResp {
1: required bool cancelled
- 2: optional string messsga
+ 2: optional string messsage
}
-struct ShcameFetchReqest {
+struct SchemeFetchRequest {
1: required binary serializedPathPatternTree
2: required bool isPrefixMatchPath
}
-struct ShcameFetchResponse {
- 1: required binary serializedSchameTree
+struct SchemeFetchResponse {
+ 1: required binary serializedSchemeTree
Review comment:
```suggestion
1: required binary serializedSchemaTree
```
##########
File path: thrift/src/main/thrift/mpp.thrift
##########
@@ -82,16 +82,16 @@ struct TCancelFragmentInstanceReq {
struct TCancelResp {
1: required bool cancelled
- 2: optional string messsga
+ 2: optional string messsage
}
-struct ShcameFetchReqest {
+struct SchemeFetchRequest {
1: required binary serializedPathPatternTree
2: required bool isPrefixMatchPath
}
-struct ShcameFetchResponse {
- 1: required binary serializedSchameTree
+struct SchemeFetchResponse {
Review comment:
```suggestion
struct SchemaFetchResponse {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org