You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "giorgigagnidze16 (via GitHub)" <gi...@apache.org> on 2025/02/14 08:46:53 UTC
[I] Simplify bitwise operations in DefaultVectorUtilSupport [lucene]
giorgigagnidze16 opened a new issue, #14240:
URL: https://github.com/apache/lucene/issues/14240
### Description
Currently, `DefaultVectorUtilSupport` contains methods that use unnecessary bitwise operations. These can be replaced with direct values to eliminate extra computations. For example, instead of `a.length & ~(4 - 1)`, simply use `a.length & -4`, and so on. A minor change would be necessary for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Simplify bitwise operations in DefaultVectorUtilSupport [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on issue #14240:
URL: https://github.com/apache/lucene/issues/14240#issuecomment-2658992237
That shouldn't be required. Have you checked out https://github.com/apache/lucene/blob/main/CONTRIBUTING.md? Feel free to let me know if there is a step that isn't clear to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Simplify bitwise operations in DefaultVectorUtilSupport [lucene]
Posted by "giorgigagnidze16 (via GitHub)" <gi...@apache.org>.
giorgigagnidze16 commented on issue #14240:
URL: https://github.com/apache/lucene/issues/14240#issuecomment-2659053672
Figured it out, thanks. Didn't realize people were forking the repos first, #14242 Here's the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Simplify bitwise operations in DefaultVectorUtilSupport [lucene]
Posted by "giorgigagnidze16 (via GitHub)" <gi...@apache.org>.
giorgigagnidze16 commented on issue #14240:
URL: https://github.com/apache/lucene/issues/14240#issuecomment-2658975225
@jpountz Sure, but I couldn't figure out how to :) Need to be added to contributors list somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Simplify bitwise operations in DefaultVectorUtilSupport [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on issue #14240:
URL: https://github.com/apache/lucene/issues/14240#issuecomment-2658971004
Would you like to open a pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Simplify bitwise operations in DefaultVectorUtilSupport [lucene]
Posted by "giorgigagnidze16 (via GitHub)" <gi...@apache.org>.
giorgigagnidze16 closed issue #14240: Simplify bitwise operations in DefaultVectorUtilSupport
URL: https://github.com/apache/lucene/issues/14240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org