You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/10/20 06:55:15 UTC
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11744
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
[rebalancer] location-aware rebalancer (part 3/n)
Some refactoring on the rebalancer code:
* Separated rebalancer-relevant information from KsckResults into
a dedicated ClusterRawInfo structure.
* Added ClusterInfo structure; ClusterBalanceInfo is aggregated
into the new ClusterInfo structure as a sub-field.
Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
---
M src/kudu/tools/rebalance-test.cc
M src/kudu/tools/rebalance_algo-test.cc
M src/kudu/tools/rebalance_algo.cc
M src/kudu/tools/rebalance_algo.h
M src/kudu/tools/rebalancer.cc
M src/kudu/tools/rebalancer.h
6 files changed, 137 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/11744/1
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11744 )
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 22 Oct 2018 19:52:17 +0000
Gerrit-HasComments: No
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11744 )
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Oct 2018 20:33:36 +0000
Gerrit-HasComments: No
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11744 )
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11744 )
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
[rebalancer] location-aware rebalancer (part 3/n)
Some refactoring on the rebalancer code:
* Separated rebalancer-relevant information from KsckResults into
a dedicated ClusterRawInfo structure.
* Added ClusterInfo structure; ClusterBalanceInfo is aggregated
into the new ClusterInfo structure as a sub-field.
Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Reviewed-on: http://gerrit.cloudera.org:8080/11744
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/tools/rebalance-test.cc
M src/kudu/tools/rebalance_algo-test.cc
M src/kudu/tools/rebalance_algo.cc
M src/kudu/tools/rebalance_algo.h
M src/kudu/tools/rebalancer.cc
M src/kudu/tools/rebalancer.h
6 files changed, 135 insertions(+), 108 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11744 )
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 23:01:21 +0000
Gerrit-HasComments: No
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11744 )
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
Patch Set 2: Verified+1
Unrelated flake in AdminCliTest.TestSimultaneousLeaderTransferAndAbruptStepdown (ASAN).
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:25:38 +0000
Gerrit-HasComments: No
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11744
to look at the new patch set (#2).
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
[rebalancer] location-aware rebalancer (part 3/n)
Some refactoring on the rebalancer code:
* Separated rebalancer-relevant information from KsckResults into
a dedicated ClusterRawInfo structure.
* Added ClusterInfo structure; ClusterBalanceInfo is aggregated
into the new ClusterInfo structure as a sub-field.
Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
---
M src/kudu/tools/rebalance-test.cc
M src/kudu/tools/rebalance_algo-test.cc
M src/kudu/tools/rebalance_algo.cc
M src/kudu/tools/rebalance_algo.h
M src/kudu/tools/rebalancer.cc
M src/kudu/tools/rebalancer.h
6 files changed, 135 insertions(+), 108 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/11744/2
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [rebalancer] location-aware rebalancer (part 3/n)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11744 )
Change subject: [rebalancer] location-aware rebalancer (part 3/n)
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11744/1/src/kudu/tools/rebalance_algo.cc
File src/kudu/tools/rebalance_algo.cc:
http://gerrit.cloudera.org:8080/#/c/11744/1/src/kudu/tools/rebalance_algo.cc@39
PS1, Line 39: using std::set_intersection;
> warning: using decl 'endl' is unused [misc-unused-using-decls]
Done
http://gerrit.cloudera.org:8080/#/c/11744/1/src/kudu/tools/rebalance_algo.cc@40
PS1, Line 40: using std::shuffle;
> warning: using decl 'multimap' is unused [misc-unused-using-decls]
Done
http://gerrit.cloudera.org:8080/#/c/11744/1/src/kudu/tools/rebalance_algo.cc@47
PS1, Line 47: namespace tools {
> warning: using decl 'unordered_map' is unused [misc-unused-using-decls]
Done
--
To view, visit http://gerrit.cloudera.org:8080/11744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89f1958238dbc28b44111038d4b82f49f824ca9
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Oct 2018 05:26:28 +0000
Gerrit-HasComments: Yes