You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2022/04/07 21:28:56 UTC

[royale-compiler] branch develop updated (b03906bae -> fcbb1b0e1)

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git


    from b03906bae Fix --watch issue where binding data was incorrectly lost when rewriting .js files
     new d90a32d76 royale-maven-plugin: handle simplified exit codes in tools from commit dd44cbbc4c0bdf936b243f91a6ef42006a3aa5e7
     new 7cc944c11 royale-maven-plugin: more specific error message for exit code from --watch compiler option
     new fcbb1b0e1 royale-maven-plugin: if --watch compiler option is specified, sleep the thread indefinitely so that it doesn't exit

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../src/main/java/org/apache/royale/maven/BaseMojo.java      | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)


[royale-compiler] 03/03: royale-maven-plugin: if --watch compiler option is specified, sleep the thread indefinitely so that it doesn't exit

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git

commit fcbb1b0e11edfeae250bb7a8bab9a9866e0955a7
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 7 14:28:38 2022 -0700

    royale-maven-plugin: if --watch compiler option is specified, sleep the thread indefinitely so that it doesn't exit
---
 .../src/main/java/org/apache/royale/maven/BaseMojo.java           | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java b/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
index 8dc26568a..70826b782 100644
--- a/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
+++ b/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
@@ -385,8 +385,14 @@ public abstract class BaseMojo
     }
 
     protected void handleExitCode(int exitCode) throws MojoExecutionException {
+        // if the --watch compiler option was specified, don't continue
         if(exitCode == 1000) {
-            throw new MojoExecutionException("The --watch compiler option is not supported by royale-maven-plugin");
+            try {
+                while(true) {
+                    Thread.sleep(60000);
+                }
+            }
+            catch(InterruptedException e) {}
         }
         if(exitCode != 0) {
             throw new MojoExecutionException("There were errors during the build. Got return code " + exitCode);


[royale-compiler] 01/03: royale-maven-plugin: handle simplified exit codes in tools from commit dd44cbbc4c0bdf936b243f91a6ef42006a3aa5e7

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git

commit d90a32d764be293676e27fb06e0546a245ab5a5c
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 7 14:06:16 2022 -0700

    royale-maven-plugin: handle simplified exit codes in tools from commit dd44cbbc4c0bdf936b243f91a6ef42006a3aa5e7
    
    There is no longer a non-zero exit code for warnings only
---
 .../src/main/java/org/apache/royale/maven/BaseMojo.java                | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java b/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
index a72a0fb66..26ff794a4 100644
--- a/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
+++ b/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
@@ -385,8 +385,7 @@ public abstract class BaseMojo
     }
 
     protected void handleExitCode(int exitCode) throws MojoExecutionException {
-        // Allow normal execution and execution with warnings.
-        if(!((exitCode == 0) || (!failOnCompilerWarnings && (exitCode == 2)))) {
+        if(exitCode != 0) {
             throw new MojoExecutionException("There were errors during the build. Got return code " + exitCode);
         }
     }


[royale-compiler] 02/03: royale-maven-plugin: more specific error message for exit code from --watch compiler option

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git

commit 7cc944c1115db5186c85b11f076ced1d1de2ebb7
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 7 14:07:34 2022 -0700

    royale-maven-plugin: more specific error message for exit code from --watch compiler option
    
    Using --watch might be allowed in the future, but for now, we should explain that it doesn't work
---
 .../src/main/java/org/apache/royale/maven/BaseMojo.java                | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java b/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
index 26ff794a4..8dc26568a 100644
--- a/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
+++ b/royale-maven-plugin/src/main/java/org/apache/royale/maven/BaseMojo.java
@@ -385,6 +385,9 @@ public abstract class BaseMojo
     }
 
     protected void handleExitCode(int exitCode) throws MojoExecutionException {
+        if(exitCode == 1000) {
+            throw new MojoExecutionException("The --watch compiler option is not supported by royale-maven-plugin");
+        }
         if(exitCode != 0) {
             throw new MojoExecutionException("There were errors during the build. Got return code " + exitCode);
         }