You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2026/02/01 03:27:39 UTC
[PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
CalvinKirs opened a new pull request, #60407:
URL: https://github.com/apache/doris/pull/60407
# Doris FE Authentication (fe-authentication)
This directory contains the modular authentication stack for Doris FE. It defines protocol-agnostic
models, a plugin SPI, a handler/orchestrator, and built-in plugin stubs. In the current phase, there
are **no changes in fe-core**; the handler is intentionally independent and can run with in-memory
registries.
For the full design rationale and details, see `auth.md`.
## Scope and status (Phase 1)
Implemented now:
- Protocol-agnostic request/response models (`AuthenticationRequest`, `AuthenticationResult`).
- Core domain models (`AuthenticationProfile`, `AuthenticationBinding`, `Principal`, `Identity`, `Subject`).
- Plugin SPI with lifecycle hooks (`validate/initialize/healthCheck/reload/close`).
- Handler orchestration (`AuthenticationService`, `BindingResolver`, `PluginManager`).
- In-memory registries (`ProfileRegistry`, `BindingRegistry`).
- Built-in plugin skeletons (Password plugin is present but **not wired to fe-core**).
Not yet wired (planned):
- fe-core integration (user/role/audit/persistence).
- Protocol adapters (MySQL/PG/HTTP/Flight) to construct `AuthenticationRequest`.
- DDL and persistence for profiles/bindings.
- Real implementations for LDAP/OIDC/Kerberos/X509/JWT plugins.
- External plugin packaging and hot-reload tooling.
## Module layout
- `fe-authentication-api`
- Domain models and request/identity objects.
- `fe-authentication-spi`
- Authentication plugin SPI (`AuthenticationPlugin`, `AuthenticationPluginFactory`, `AuthenticationResult`).
- `fe-authentication-handler`
- Orchestration logic: profile/binding selection, plugin lifecycle, request processing.
- `fe-authentication-plugins`
- Built-in plugins (currently Password plugin stub).
- `fe-extension-spi` / `fe-extension-loader`
- Shared plugin framework and classloader support for external extensions.
## Architecture (current)
Dependency graph (compile-time):
```
fe-extension-spi/loader -> fe-authentication-handler / fe-authentication-plugins
fe-authentication-api <-- fe-authentication-spi <-- fe-authentication-handler <-- fe-core (future)
^ ^
| |
fe-authentication-plugins --------------
```
Runtime flow (simplified):
```
Protocol Adapter
-> AuthenticationRequest
-> AuthenticationService
-> BindingResolver (ProfileRegistry + BindingRegistry)
-> PluginManager (AuthenticationPluginFactory / AuthenticationPlugin)
-> AuthenticationOutcome (Subject + AuthenticationResult)
```
### Profile selection order
1. User binding (explicit)
2. Requested profile (`AuthenticationRequest.requestedProfile` or request properties
`auth_profile` / `requested_profile`)
3. Default bindings
4. System default password profile (`AuthenticationProfile.createDefault()`)
If a profile is disabled and the binding is mandatory, resolution fails; otherwise it falls back.
## Developer usage (today)
### 1) Create profiles and bindings
```java
ProfileRegistry profiles = new ProfileRegistry();
profiles.register(AuthenticationProfile.createDefault());
AuthenticationProfile ldap = AuthenticationProfile.builder()
.name("corp_ldap")
.pluginType(AuthenticationPluginType.LDAP)
.enabled(true)
.priority(10)
.configProperty("ldap_server", "ldap://ldap.example.com:389")
.configProperty("ldap_base_dn", "dc=example,dc=com")
.mapRole("developers", "dev_role")
.build();
profiles.register(ldap);
BindingRegistry bindings = new BindingRegistry();
bindings.putUserBinding("alice",
new AuthenticationBinding(AuthenticationBinding.BindingType.USER,
"alice", "corp_ldap", 1, false));
```
### 2) Build request and authenticate
```java
PluginManager pluginManager = new PluginManager();
BindingResolver resolver = new BindingResolver(profiles, bindings);
AuthenticationService service = new AuthenticationService(profiles, pluginManager, resolver);
AuthenticationRequest request = AuthenticationRequest.builder()
.username("alice")
.credentialType(CredentialType.CLEAR_TEXT_PASSWORD)
.credential("secret".getBytes(StandardCharsets.UTF_8))
.protocol("mysql")
.requestedProfile("corp_ldap")
.build();
AuthenticationOutcome outcome = service.authenticateWithOutcome(request);
```
Notes:
- `PluginManager` uses `ServiceLoader` to discover `AuthenticationPluginFactory` on the classpath.
Provide `META-INF/services/org.apache.doris.authentication.spi.AuthenticationPluginFactory` in
plugin jars to enable discovery.
- The built-in Password plugin currently throws `AuthenticationException` because fe-core wiring
is not done yet.
## Plugin development (SPI)
Implement:
- `AuthenticationPlugin` (business logic, supports/validate/initialize/authenticate)
- `AuthenticationPluginFactory` (creates plugin instances)
ServiceLoader file:
```
META-INF/services/org.apache.doris.authentication.spi.AuthenticationPluginFactory
```
External plugin packaging (planned):
```
plugin-name/
plugin.properties
plugin.jar
lib/
```
`plugin.properties` fields (recommended):
```
name = ldap
version = 1.0.0
spiVersion = 1
factoryClass = org.apache.doris.authentication.plugins.LdapPluginFactory
```
Classloader rules (planned):
- Parent-first: `java.*`, logging, and Doris SPI/API packages
- Child-first: plugin packages and private dependencies
## Planned user experience (future)
Proposed DDL (subject to final syntax):
```sql
CREATE AUTHENTICATION PROFILE corp_ldap
PLUGIN = 'ldap'
PROPERTIES (
'ldap_server' = 'ldap://ldap.example.com:389',
'ldap_base_dn' = 'dc=example,dc=com'
)
ROLE_MAPPING (
'developers' = 'dev_role'
)
JIT_USER_ENABLED = true
PRIORITY = 10;
ALTER USER alice BIND AUTHENTICATION PROFILE corp_ldap;
CREATE AUTHENTICATION BINDING DEFAULT USING __default_password__ PRIORITY 100;
```
Multi-step authentication:
- Plugins may return `AuthenticationResult.CONTINUE` with challenge data.
- Protocol adapters will forward the challenge and resume with `authState` and credential.
## Integration plan (future adaptation)
- fe-core adapter layer:
- Password validation will reuse existing password logic.
- User creation/JIT and role resolution will use fe-core managers.
- Audit events will be emitted by the handler.
- Protocol adapters:
- Convert protocol-specific packets into `AuthenticationRequest`.
- Handle challenge/response for multi-step flows.
- Persistence:
- Profiles and bindings stored in edit log/metadata and exposed to handler registries.
## Compatibility and migration
- Default password profile keeps existing password auth behavior once wired.
- New profiles can be rolled out incrementally without changing protocol code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #60407:
URL: https://github.com/apache/doris/pull/60407#discussion_r2779347938
##########
fe/fe-authentication/fe-authentication-handler/src/main/java/org/apache/doris/authentication/handler/PluginManager.java:
##########
@@ -0,0 +1,195 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.authentication.handler;
+
+import org.apache.doris.authentication.AuthenticationPluginType;
+import org.apache.doris.authentication.AuthenticationProfile;
+import org.apache.doris.authentication.spi.AuthenticationException;
+import org.apache.doris.authentication.spi.AuthenticationPlugin;
+import org.apache.doris.authentication.spi.AuthenticationPluginFactory;
+import org.apache.doris.extension.loader.ChildFirstClassLoader;
+import org.apache.doris.extension.loader.PluginLoader;
+import org.apache.doris.extension.spi.PluginDescriptor;
+import org.apache.doris.extension.spi.PluginException;
+import org.apache.doris.extension.spi.PluginFactory;
+
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.ServiceLoader;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Manager for authentication plugins.
+ *
+ * <p>Handles plugin instance lifecycle: creation, caching, health checks, reloading.
+ * Uses {@link ServiceLoader} for classpath plugins and {@link PluginLoader}
+ * for external plugins.</p>
+ */
+public class PluginManager {
Review Comment:
```suggestion
public class AuthPluginManager {
```
##########
fe/fe-authentication/fe-authentication-api/src/main/java/org/apache/doris/authentication/Subject.java:
##########
@@ -0,0 +1,257 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.authentication;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+
+/**
+ * Authorization subject representing a user session.
+ *
+ * <p>Subject is the authorization-layer representation of an authenticated user.
+ * It contains the user identity (via {@link Principal}) plus role information
+ * needed for access control decisions.
+ *
+ * <p>Design note: Subject focuses purely on authorization concerns:
+ * <ul>
+ * <li>WHO - the authenticated principal</li>
+ * <li>WHAT ROLES - active and available roles</li>
+ * <li>WHERE FROM - source IP for IP-based access control</li>
+ * </ul>
+ *
+ * <p>Protocol-specific information (connection type, client info) belongs
+ * in the session context, not the Subject.
+ *
+ * <p>This design follows the standard security pattern where:
+ * <ul>
+ * <li>Authentication produces a Principal</li>
+ * <li>Principal + Roles = Subject</li>
+ * <li>Subject is used for authorization decisions</li>
+ * </ul>
+ *
+ * @see Principal
+ * @see Identity
+ */
+public final class Subject {
Review Comment:
what is diff between Subject and Principal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3883897052
<details>
<summary>TPC-H: <b>Total hot run time: 30444 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f5237fa75b40921a01d4481e1ee748bdce525457, data reload: false
------ Round 1 ----------------------------------
q1 17647 4584 4324 4324
q2 2045 391 233 233
q3 10130 1276 727 727
q4 10189 776 315 315
q5 7511 2167 1911 1911
q6 192 178 146 146
q7 893 742 604 604
q8 9265 1378 1115 1115
q9 4680 4598 4600 4598
q10 6781 1948 1531 1531
q11 449 254 236 236
q12 333 372 217 217
q13 17770 4078 3225 3225
q14 228 225 208 208
q15 883 804 790 790
q16 662 683 623 623
q17 691 851 513 513
q18 6525 5854 6023 5854
q19 1139 1104 673 673
q20 576 553 394 394
q21 2735 1989 1947 1947
q22 358 304 260 260
Total cold run time: 101682 ms
Total hot run time: 30444 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4583 4571 4683 4571
q2 254 342 239 239
q3 2271 2828 2438 2438
q4 1513 1953 1431 1431
q5 4573 4672 4456 4456
q6 215 175 133 133
q7 1955 1903 1767 1767
q8 2863 2416 2456 2416
q9 7674 7461 7548 7461
q10 2828 3082 2690 2690
q11 502 433 417 417
q12 675 778 595 595
q13 3883 4378 3663 3663
q14 288 317 268 268
q15 848 786 781 781
q16 636 688 636 636
q17 1066 1261 1270 1261
q18 7649 7295 7360 7295
q19 800 830 788 788
q20 1913 2020 1842 1842
q21 4492 4187 4118 4118
q22 469 458 410 410
Total cold run time: 51950 ms
Total hot run time: 49676 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3948399750
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3895787131
<details>
<summary>TPC-H: <b>Total hot run time: 28942 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 65bffba893b075a5099ddf0f1695ecae88d22267, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17653 4427 4305 4305
q2 q3 10660 768 513 513
q4 4685 355 254 254
q5 7552 1190 1008 1008
q6 176 176 150 150
q7 782 850 662 662
q8 9285 1456 1367 1367
q9 4866 4723 4693 4693
q10 6810 1857 1653 1653
q11 481 269 237 237
q12 696 563 481 481
q13 17800 4227 3408 3408
q14 227 224 220 220
q15 944 791 814 791
q16 759 735 658 658
q17 717 845 438 438
q18 6156 5287 5350 5287
q19 1096 967 632 632
q20 524 489 393 393
q21 4604 2015 1528 1528
q22 401 313 264 264
Total cold run time: 96874 ms
Total hot run time: 28942 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4618 4688 4552 4552
q2 q3 1804 2231 1762 1762
q4 888 1190 765 765
q5 4044 4394 4298 4298
q6 182 170 142 142
q7 1765 1644 1518 1518
q8 2509 2748 2580 2580
q9 7497 7414 7491 7414
q10 2671 2829 2386 2386
q11 503 457 431 431
q12 503 597 456 456
q13 4124 4748 3591 3591
q14 290 309 294 294
q15 866 800 803 800
q16 728 755 717 717
q17 1193 1490 1314 1314
q18 7147 6872 6703 6703
q19 878 897 909 897
q20 2124 2203 2044 2044
q21 4015 3510 3352 3352
q22 478 471 441 441
Total cold run time: 48827 ms
Total hot run time: 46457 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3883758329
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #60407:
URL: https://github.com/apache/doris/pull/60407#discussion_r2779339657
##########
fe/fe-authentication/fe-authentication-api/src/main/java/org/apache/doris/authentication/AuthenticationPluginType.java:
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.authentication;
+
+/**
+ * Authentication plugin type enumeration.
+ */
+public enum AuthenticationPluginType {
Review Comment:
if this is hardcoded, what if user implement a new type that is not included here? Do they have to modify this file too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3884537918
<details>
<summary>ClickBench: <b>Total hot run time: 28.12 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 80fd9c8ddc93d1855e9b1a27a59d7341e8262f89, data reload: false
query1 0.05 0.05 0.04
query2 0.10 0.04 0.04
query3 0.25 0.09 0.08
query4 1.60 0.12 0.10
query5 0.29 0.25 0.24
query6 1.17 0.67 0.68
query7 0.03 0.02 0.03
query8 0.05 0.04 0.03
query9 0.57 0.50 0.49
query10 0.55 0.56 0.53
query11 0.14 0.09 0.09
query12 0.14 0.10 0.10
query13 0.64 0.61 0.62
query14 1.07 1.07 1.05
query15 0.89 0.87 0.88
query16 0.39 0.40 0.39
query17 1.15 1.07 1.16
query18 0.22 0.21 0.21
query19 2.03 1.96 1.92
query20 0.01 0.02 0.01
query21 15.42 0.28 0.14
query22 5.29 0.06 0.06
query23 16.11 0.30 0.11
query24 0.98 0.65 0.18
query25 0.10 0.06 0.12
query26 0.14 0.13 0.14
query27 0.09 0.05 0.06
query28 4.31 1.15 0.97
query29 12.61 4.01 3.24
query30 0.26 0.13 0.11
query31 2.82 0.65 0.40
query32 3.23 0.60 0.49
query33 3.32 3.21 3.26
query34 15.95 5.38 4.75
query35 4.91 4.79 4.81
query36 0.65 0.50 0.49
query37 0.11 0.07 0.07
query38 0.07 0.04 0.04
query39 0.05 0.03 0.03
query40 0.20 0.16 0.15
query41 0.09 0.04 0.03
query42 0.05 0.03 0.03
query43 0.04 0.03 0.04
Total cold run time: 98.14 s
Total hot run time: 28.12 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs merged PR #60407:
URL: https://github.com/apache/doris/pull/60407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #60407:
URL: https://github.com/apache/doris/pull/60407#discussion_r2779343394
##########
fe/fe-authentication/fe-authentication-spi/src/main/java/org/apache/doris/authentication/spi/AuthenticationResult.java:
##########
@@ -0,0 +1,261 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.authentication.spi;
+
+import org.apache.doris.authentication.Identity;
+import org.apache.doris.authentication.Principal;
+
+import java.util.Objects;
+import java.util.Optional;
+
+/**
+ * Authentication result returned by authenticator plugins.
+ *
+ * <p>Authentication can result in one of three states:
+ * <ul>
+ * <li>{@link Status#SUCCESS} - Authentication succeeded, principal is available</li>
+ * <li>{@link Status#CONTINUE} - Multi-step auth, more data needed from client</li>
+ * <li>{@link Status#FAILURE} - Authentication failed, exception explains why</li>
+ * </ul>
+ *
+ * <p>Use the static factory methods to create instances:
+ * <pre>{@code
+ * // Success
+ * return AuthenticationResult.success(identity);
+ *
+ * // Need more data (multi-step)
+ * return AuthenticationResult.continueWith(state, challengeData);
+ *
+ * // Failure
+ * return AuthenticationResult.failure(new AuthenticationException("Invalid password"));
+ * }</pre>
+ */
+public final class AuthenticationResult {
Review Comment:
1. why final? are you sure we can use same request/result for all types of authemtication?
2. why put `result` in SPI but `request` in API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3948485154
<details>
<summary>TPC-H: <b>Total hot run time: 28807 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 20af5c1dc20ec78c6b178c25e03b8c5140a246ed, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17605 4453 4263 4263
q2 q3 10651 774 519 519
q4 4677 355 249 249
q5 7557 1210 1030 1030
q6 174 176 145 145
q7 767 849 647 647
q8 9289 1461 1276 1276
q9 4750 4772 4677 4677
q10 6773 1873 1642 1642
q11 477 259 247 247
q12 700 584 471 471
q13 17787 4277 3417 3417
q14 233 234 210 210
q15 892 799 789 789
q16 732 716 683 683
q17 720 862 412 412
q18 5942 5504 5312 5312
q19 1250 975 615 615
q20 516 490 399 399
q21 4849 1966 1521 1521
q22 398 313 283 283
Total cold run time: 96739 ms
Total hot run time: 28807 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4652 4529 4511 4511
q2 q3 1775 2197 1781 1781
q4 887 1213 776 776
q5 4084 4372 4290 4290
q6 196 184 152 152
q7 1823 1650 1530 1530
q8 2560 2661 2552 2552
q9 7436 7157 7420 7157
q10 2701 2891 2433 2433
q11 491 429 411 411
q12 512 586 442 442
q13 3930 4459 3650 3650
q14 285 293 270 270
q15 854 867 825 825
q16 727 751 724 724
q17 1179 1521 1318 1318
q18 7077 7120 6575 6575
q19 869 901 885 885
q20 2117 2166 2111 2111
q21 3990 3463 3351 3351
q22 474 491 421 421
Total cold run time: 48619 ms
Total hot run time: 46165 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3948520585
<details>
<summary>TPC-DS: <b>Total hot run time: 183491 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 20af5c1dc20ec78c6b178c25e03b8c5140a246ed, data reload: false
query5 5070 628 520 520
query6 346 233 218 218
query7 4226 495 278 278
query8 352 252 239 239
query9 8750 2779 2798 2779
query10 551 392 334 334
query11 16948 17344 17099 17099
query12 201 131 132 131
query13 1364 485 377 377
query14 7340 3410 3174 3174
query14_1 2950 2944 2994 2944
query15 214 215 179 179
query16 1003 482 466 466
query17 1373 790 660 660
query18 2787 432 340 340
query19 214 204 180 180
query20 136 122 124 122
query21 211 137 112 112
query22 4724 5050 4696 4696
query23 17224 16685 16495 16495
query23_1 16651 16567 16717 16567
query24 7097 1599 1221 1221
query24_1 1218 1248 1247 1247
query25 538 496 409 409
query26 1237 257 150 150
query27 2766 472 284 284
query28 4478 1865 1874 1865
query29 788 558 469 469
query30 307 248 217 217
query31 871 728 668 668
query32 78 76 71 71
query33 519 330 285 285
query34 939 909 566 566
query35 637 692 599 599
query36 1068 1130 958 958
query37 132 89 80 80
query38 2957 2924 2864 2864
query39 1007 963 862 862
query39_1 829 962 824 824
query40 227 148 138 138
query41 62 59 58 58
query42 107 106 103 103
query43 382 384 366 366
query44
query45 197 190 183 183
query46 884 1001 610 610
query47 2148 2156 2041 2041
query48 327 313 228 228
query49 627 475 390 390
query50 712 281 226 226
query51 4103 4048 4048 4048
query52 109 108 99 99
query53 294 333 280 280
query54 300 266 258 258
query55 97 91 84 84
query56 315 313 325 313
query57 1375 1325 1274 1274
query58 292 277 272 272
query59 2581 2699 2544 2544
query60 358 339 325 325
query61 153 143 145 143
query62 614 566 544 544
query63 312 274 283 274
query64 4884 1260 991 991
query65
query66 1387 467 379 379
query67 16258 16455 16210 16210
query68
query69 405 332 303 303
query70 983 1000 954 954
query71 340 322 295 295
query72 2964 2728 2420 2420
query73 546 563 323 323
query74 9980 9925 9806 9806
query75 2867 2756 2452 2452
query76 2299 1028 695 695
query77 363 397 314 314
query78 11213 11358 10693 10693
query79 1902 802 602 602
query80 1389 622 581 581
query81 555 279 260 260
query82 974 154 114 114
query83 350 257 248 248
query84 255 112 99 99
query85 918 472 430 430
query86 415 308 296 296
query87 3075 3155 3013 3013
query88 3588 2698 2644 2644
query89 422 368 341 341
query90 1967 182 179 179
query91 165 154 134 134
query92 78 79 73 73
query93 997 817 509 509
query94 649 332 294 294
query95 594 398 323 323
query96 682 529 228 228
query97 2466 2477 2408 2408
query98 239 244 215 215
query99 1016 978 895 895
Total cold run time: 255313 ms
Total hot run time: 183491 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3884188703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3895880818
<details>
<summary>TPC-DS: <b>Total hot run time: 185336 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 65bffba893b075a5099ddf0f1695ecae88d22267, data reload: false
query5 4324 648 526 526
query6 323 229 225 225
query7 4224 477 290 290
query8 358 256 243 243
query9 8738 2786 2795 2786
query10 517 372 351 351
query11 17146 17747 17280 17280
query12 185 136 127 127
query13 1306 487 365 365
query14 7160 3363 3021 3021
query14_1 3073 3014 2900 2900
query15 204 204 181 181
query16 1069 494 473 473
query17 1200 711 639 639
query18 2614 470 364 364
query19 223 204 206 204
query20 161 157 142 142
query21 218 166 129 129
query22 4881 4843 4739 4739
query23 17303 16914 16690 16690
query23_1 16762 16818 16789 16789
query24 7133 1624 1253 1253
query24_1 1233 1219 1215 1215
query25 560 483 455 455
query26 1214 275 164 164
query27 2753 467 285 285
query28 4524 1879 1868 1868
query29 804 561 470 470
query30 314 246 210 210
query31 859 725 663 663
query32 80 76 68 68
query33 512 338 273 273
query34 902 902 584 584
query35 633 668 632 632
query36 1088 1072 983 983
query37 129 95 86 86
query38 2957 2970 2864 2864
query39 1037 831 810 810
query39_1 803 794 812 794
query40 236 151 138 138
query41 63 59 58 58
query42 105 102 106 102
query43 391 385 361 361
query44
query45 200 187 187 187
query46 872 982 607 607
query47 2123 2144 2044 2044
query48 310 306 233 233
query49 627 458 379 379
query50 672 286 215 215
query51 4084 4158 4091 4091
query52 109 108 97 97
query53 293 333 288 288
query54 291 264 263 263
query55 91 87 85 85
query56 329 321 338 321
query57 1342 1345 1294 1294
query58 298 276 278 276
query59 2602 2719 2540 2540
query60 336 324 327 324
query61 147 146 153 146
query62 632 610 550 550
query63 312 276 283 276
query64 4935 1275 991 991
query65
query66 1442 479 357 357
query67 16418 16496 16476 16476
query68
query69 397 307 285 285
query70 1022 990 950 950
query71 337 313 315 313
query72 2751 2856 2585 2585
query73 528 551 331 331
query74 9623 9599 9389 9389
query75 2877 2767 2484 2484
query76 2330 1047 695 695
query77 385 383 320 320
query78 11632 11768 11134 11134
query79 2335 823 658 658
query80 1712 643 573 573
query81 566 292 261 261
query82 981 152 119 119
query83 330 269 251 251
query84 254 120 103 103
query85 966 564 430 430
query86 428 304 323 304
query87 3149 3093 2988 2988
query88 3579 2700 2695 2695
query89 423 368 347 347
query90 1998 179 179 179
query91 161 155 130 130
query92 81 79 73 73
query93 999 828 514 514
query94 637 310 289 289
query95 577 336 311 311
query96 636 513 233 233
query97 2479 2503 2441 2441
query98 235 223 226 223
query99 998 957 876 876
Total cold run time: 256518 ms
Total hot run time: 185336 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3830258985
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3956103131
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3895553997
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3884511620
<details>
<summary>TPC-DS: <b>Total hot run time: 190545 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 80fd9c8ddc93d1855e9b1a27a59d7341e8262f89, data reload: false
query5 4334 597 489 489
query6 356 236 213 213
query7 4219 464 262 262
query8 340 251 232 232
query9 8735 2714 2720 2714
query10 459 369 331 331
query11 16459 16521 16083 16083
query12 183 123 117 117
query13 1261 470 347 347
query14 6229 3199 2928 2928
query14_1 2815 2792 2777 2777
query15 202 193 177 177
query16 1001 471 452 452
query17 1090 689 593 593
query18 2479 439 346 346
query19 212 206 183 183
query20 131 127 123 123
query21 218 144 132 132
query22 5100 4860 4847 4847
query23 19275 18601 18254 18254
query23_1 18658 18503 18523 18503
query24 7234 1609 1200 1200
query24_1 1202 1219 1232 1219
query25 546 462 415 415
query26 1251 265 159 159
query27 2760 458 306 306
query28 4470 1866 1864 1864
query29 778 556 464 464
query30 318 273 218 218
query31 854 748 683 683
query32 88 78 79 78
query33 571 337 288 288
query34 915 898 578 578
query35 642 675 601 601
query36 1110 1131 964 964
query37 137 100 82 82
query38 2943 2873 2844 2844
query39 934 899 892 892
query39_1 869 889 877 877
query40 222 129 117 117
query41 69 62 70 62
query42 110 104 104 104
query43 401 425 403 403
query44 1322 718 714 714
query45 194 190 184 184
query46 894 984 602 602
query47 2137 2216 2138 2138
query48 312 318 236 236
query49 609 427 362 362
query50 668 271 211 211
query51 4071 4099 4074 4074
query52 103 103 94 94
query53 295 361 272 272
query54 292 259 255 255
query55 83 79 76 76
query56 293 303 315 303
query57 1440 1343 1291 1291
query58 282 260 253 253
query59 2030 2109 2116 2109
query60 334 326 308 308
query61 148 143 149 143
query62 597 585 519 519
query63 291 264 267 264
query64 4816 1238 927 927
query65 4536 4449 4369 4369
query66 1445 458 337 337
query67 16187 16516 16161 16161
query68 2430 1067 722 722
query69 425 311 280 280
query70 1043 950 905 905
query71 331 305 299 299
query72 2928 2767 2592 2592
query73 529 554 306 306
query74 9745 9609 9530 9530
query75 2813 2768 2433 2433
query76 2292 1058 629 629
query77 351 360 287 287
query78 11465 11460 10931 10931
query79 2176 915 587 587
query80 1641 554 479 479
query81 572 283 260 260
query82 943 147 115 115
query83 369 251 238 238
query84 251 120 92 92
query85 883 469 416 416
query86 411 336 291 291
query87 3127 3087 3024 3024
query88 3555 2649 2633 2633
query89 386 346 334 334
query90 1913 172 160 160
query91 163 153 146 146
query92 79 76 66 66
query93 1076 869 476 476
query94 683 315 273 273
query95 575 341 308 308
query96 653 503 227 227
query97 2461 2494 2388 2388
query98 232 207 205 205
query99 911 925 893 893
Total cold run time: 264469 ms
Total hot run time: 190545 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3883951044
<details>
<summary>TPC-DS: <b>Total hot run time: 190451 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f5237fa75b40921a01d4481e1ee748bdce525457, data reload: false
query5 5318 650 482 482
query6 347 224 205 205
query7 4210 452 263 263
query8 333 238 230 230
query9 8740 2748 2750 2748
query10 545 376 344 344
query11 16510 16484 16290 16290
query12 186 115 118 115
query13 1242 438 334 334
query14 6874 3172 2951 2951
query14_1 2781 2753 2800 2753
query15 219 186 169 169
query16 978 462 469 462
query17 1044 658 558 558
query18 2695 420 333 333
query19 198 198 176 176
query20 147 124 123 123
query21 217 141 125 125
query22 4864 4989 4952 4952
query23 18978 18391 18414 18391
query23_1 18427 18335 18392 18335
query24 7028 1569 1212 1212
query24_1 1206 1220 1213 1213
query25 518 437 386 386
query26 1243 270 151 151
query27 2768 454 293 293
query28 4519 1863 1846 1846
query29 752 531 442 442
query30 317 236 219 219
query31 838 726 667 667
query32 82 80 76 76
query33 525 326 269 269
query34 902 913 585 585
query35 635 680 604 604
query36 1086 1126 996 996
query37 138 97 87 87
query38 2903 2919 2838 2838
query39 934 908 909 908
query39_1 863 874 862 862
query40 219 165 116 116
query41 67 62 60 60
query42 102 97 99 97
query43 421 422 377 377
query44 1318 727 714 714
query45 202 187 188 187
query46 867 992 604 604
query47 2163 2191 2077 2077
query48 301 312 225 225
query49 613 421 346 346
query50 673 278 205 205
query51 4056 4065 3982 3982
query52 99 106 91 91
query53 282 329 268 268
query54 295 286 252 252
query55 86 83 83 83
query56 316 310 311 310
query57 1381 1357 1265 1265
query58 281 262 253 253
query59 2038 2064 2024 2024
query60 331 337 312 312
query61 151 142 144 142
query62 607 580 541 541
query63 299 271 267 267
query64 4785 1288 937 937
query65 4534 4411 4408 4408
query66 1364 447 339 339
query67 16373 16459 16226 16226
query68 2486 1048 717 717
query69 402 315 280 280
query70 1017 953 903 903
query71 329 322 295 295
query72 2956 2777 2400 2400
query73 520 558 335 335
query74 9702 9663 9470 9470
query75 2822 2776 2484 2484
query76 2283 1082 640 640
query77 349 380 301 301
query78 11247 11365 10866 10866
query79 1051 923 603 603
query80 672 588 514 514
query81 490 292 258 258
query82 1538 152 113 113
query83 361 261 239 239
query84 260 123 107 107
query85 905 557 500 500
query86 372 312 311 311
query87 3138 3076 2976 2976
query88 3569 2695 2666 2666
query89 412 350 320 320
query90 1775 182 170 170
query91 171 171 145 145
query92 80 74 72 72
query93 869 832 475 475
query94 499 365 295 295
query95 577 393 316 316
query96 648 513 227 227
query97 2479 2503 2394 2394
query98 225 212 204 204
query99 916 929 900 900
Total cold run time: 262901 ms
Total hot run time: 190451 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3883972725
<details>
<summary>ClickBench: <b>Total hot run time: 28.14 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f5237fa75b40921a01d4481e1ee748bdce525457, data reload: false
query1 0.05 0.04 0.04
query2 0.09 0.05 0.04
query3 0.26 0.09 0.08
query4 1.60 0.11 0.11
query5 0.26 0.24 0.24
query6 1.16 0.67 0.69
query7 0.03 0.03 0.02
query8 0.05 0.04 0.04
query9 0.56 0.49 0.49
query10 0.55 0.54 0.53
query11 0.15 0.09 0.10
query12 0.14 0.10 0.10
query13 0.63 0.61 0.62
query14 1.08 1.05 1.06
query15 0.87 0.86 0.89
query16 0.40 0.38 0.40
query17 1.11 1.15 1.08
query18 0.23 0.21 0.20
query19 1.99 1.96 2.03
query20 0.02 0.02 0.01
query21 15.40 0.27 0.14
query22 5.20 0.05 0.05
query23 15.89 0.28 0.11
query24 2.26 0.35 0.21
query25 0.07 0.07 0.07
query26 0.15 0.14 0.13
query27 0.09 0.07 0.06
query28 3.18 1.14 0.97
query29 12.59 4.02 3.23
query30 0.27 0.13 0.11
query31 2.82 0.63 0.40
query32 3.23 0.60 0.49
query33 3.24 3.26 3.23
query34 16.11 5.45 4.69
query35 4.82 4.79 4.82
query36 0.66 0.50 0.49
query37 0.10 0.06 0.06
query38 0.07 0.04 0.05
query39 0.04 0.03 0.03
query40 0.19 0.16 0.14
query41 0.08 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 97.77 s
Total hot run time: 28.14 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3884449587
<details>
<summary>TPC-H: <b>Total hot run time: 30004 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 80fd9c8ddc93d1855e9b1a27a59d7341e8262f89, data reload: false
------ Round 1 ----------------------------------
q1 17606 4652 4271 4271
q2 2042 350 235 235
q3 10158 1290 713 713
q4 10193 769 319 319
q5 7532 2206 1921 1921
q6 192 176 143 143
q7 891 716 604 604
q8 9269 1383 1089 1089
q9 4736 4686 4581 4581
q10 6813 1936 1557 1557
q11 467 258 241 241
q12 338 376 221 221
q13 17794 4044 3228 3228
q14 240 236 223 223
q15 880 840 797 797
q16 689 677 598 598
q17 694 796 545 545
q18 6495 5822 5732 5732
q19 1237 987 616 616
q20 500 486 386 386
q21 2505 1799 1744 1744
q22 323 281 240 240
Total cold run time: 101594 ms
Total hot run time: 30004 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4343 4316 4350 4316
q2 256 349 252 252
q3 2078 2674 2270 2270
q4 1363 1734 1301 1301
q5 4440 4412 4600 4412
q6 200 179 136 136
q7 1958 1840 1784 1784
q8 2422 2755 2470 2470
q9 7596 7402 7501 7402
q10 2865 3119 2612 2612
q11 533 440 416 416
q12 664 745 647 647
q13 3926 4465 3488 3488
q14 322 421 302 302
q15 849 825 797 797
q16 844 769 665 665
q17 1154 1339 1354 1339
q18 8332 7934 7886 7886
q19 1034 860 853 853
q20 2122 2137 2102 2102
q21 4765 4645 4441 4441
q22 521 469 407 407
Total cold run time: 52587 ms
Total hot run time: 50298 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](authentication): add fe-authentication modules (api/spi/handler/plugins) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60407:
URL: https://github.com/apache/doris/pull/60407#issuecomment-3956102641
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org