You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/08 14:38:59 UTC
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request
#3685: Optimize orchestration datasource
SteNicholas opened a new pull request #3685: Optimize orchestration datasource
URL: https://github.com/apache/incubator-shardingsphere/pull/3685
Class `OrchestrationShardingDataSource` constructor creates `ShardingDataSource` with calling twice `configService.loadDataSourceConfigurations(ShardingConstant.LOGIC_SCHEMA_NAME)`, that is unnecessary to call twice.
Changes proposed in this pull request:
- Create `dataSourceConfigurations` map with calling `configService.loadDataSourceConfigurations(ShardingConstant.LOGIC_SCHEMA_NAME)`, then use this map creates `ShardingDataSource`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services