[GitHub] [flink] XComp commented on a diff in pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

[GitBox <gi...@apache.org>]

XComp commented on code in PR #20805:
URL: https://github.com/apache/flink/pull/20805#discussion_r997847285


##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/retry/strategy/RetryOnExceptionStrategy.java:
##########
@@ -37,6 +40,12 @@ public RetryOnExceptionStrategy(
     @Override
     public void handleException(String testName, int attemptIndex, Throwable throwable)

Review Comment:
   Here's a top: Updating the JavaDoc could be something that can be moved into its own commit because it's kind of unrelated (i.e. if we want to revert the JUnit migration commit, this change is still valid and shouldn't be reverted).



##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/retry/strategy/RetryOnExceptionStrategy.java:
##########
@@ -37,6 +40,12 @@ public RetryOnExceptionStrategy(
     @Override
     public void handleException(String testName, int attemptIndex, Throwable throwable)

Review Comment:
   nit: Updating the JavaDoc could be something that can be moved into its own commit because it's kind of unrelated (i.e. if we want to revert the JUnit migration commit, this change is still valid and shouldn't be reverted).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org