[GitHub] [geode] upthewaterspout commented on a change in pull request #6093: GEODE-9003: Remove the member from replicates as GII candidate if it'…

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #6093:
URL: https://github.com/apache/geode/pull/6093#discussion_r595341190



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/persistence/PersistenceAdvisorImpl.java
##########
@@ -533,7 +533,12 @@ public boolean checkMyStateOnMembers(Set<InternalDistributedMember> replicates)
         String message = String.format(
             "Region %s remote member %s with persistent data %s was not part of the same distributed system as the local data from %s",
             regionPath, member, remoteId, myId);
-        throw new ConflictingPersistentDataException(message);
+        replicates.remove(member);

Review comment:
       We are modifying `replicates`, which is a set that was passed into this method. I'm not quite sure what is going to happen to later logic if we have removed some of the replicates from the set that gets passed in. So I think it would be better to make a copy of replicates at the top of the method, to make sure we are not breaking other logic.
   
   Otherwise, changes look good!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org