You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/05/05 06:57:02 UTC

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

tihom88 commented on code in PR #552:
URL: https://github.com/apache/jackrabbit-oak/pull/552#discussion_r865602808


##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java:
##########
@@ -130,6 +139,46 @@ private void downloadSimilaritySearchPluginIfNotExists(String localPluginPath, S
         }
     }
 
+
+
+    private ElasticConnectionConnectionModel initializeElasticConnectionModel (String elasticConnectionString) {

Review Comment:
   removed returning model.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org