[GitHub] [druid] rohangarg commented on a diff in pull request #13269: Add a OverlordHelper that cleans up durable storage objects in MSQ

[GitBox <gi...@apache.org>]

rohangarg commented on code in PR #13269:
URL: https://github.com/apache/druid/pull/13269#discussion_r1015069934


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQDurableStorageModule.java:
##########
@@ -76,6 +75,16 @@ public void configure(Binder binder)
       binder.bind(Key.get(StorageConnector.class, MultiStageQuery.class))
             .toProvider(Key.get(StorageConnectorProvider.class, MultiStageQuery.class))
             .in(LazySingleton.class);
+
+      Multibinder.newSetBinder(binder, OverlordHelper.class)
+                 .addBinding()
+                 .to(OverlordHelper.class);

Review Comment:
   should this be `DurableStorageCleaner`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org