You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/22 11:34:51 UTC

[GitHub] [rocketmq-client-go] NAND86 opened a new pull request #648: [ISSUE #646] fix responseTable memory leaks

NAND86 opened a new pull request #648:
URL: https://github.com/apache/rocketmq-client-go/pull/648

## What is the purpose of the change

ISSUE #646

## Brief changelog

- 网络异常可能会导致receiveResponse收不到响应，responseTable中的数据会越来越多（泄漏）。
- InvokeSync不会有这种问题，但是为了和InvokeAsync保持一致，做了统一修改。
- 修改为在waitResponse时从responseTable中删除ResponseFuture，processCMD收到响应后不再删除。

## Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] NAND86 commented on pull request #648: [ISSUE #646] fix responseTable memory leaks

Posted by GitBox <gi...@apache.org>.

NAND86 commented on pull request #648:
URL: https://github.com/apache/rocketmq-client-go/pull/648#issuecomment-824773356


   没搞懂为什么travis一直不过。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #648: [ISSUE #646] fix responseTable memory leaks

Posted by GitBox <gi...@apache.org>.

maixiaohai commented on pull request #648:
URL: https://github.com/apache/rocketmq-client-go/pull/648#issuecomment-824778453


   > 没搞懂为什么travis一直不过。
   
   点进去有具体报错，格式问题；
   另外你这个patch里好像有之前一个patch的提交


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] NAND86 commented on pull request #648: [ISSUE #646] fix responseTable memory leaks

Posted by GitBox <gi...@apache.org>.

NAND86 commented on pull request #648:
URL: https://github.com/apache/rocketmq-client-go/pull/648#issuecomment-824780631


   > > 没搞懂为什么travis一直不过。
   > 
   > 点进去有具体报错，格式问题；
   > 另外你这个patch里好像有之前一个patch的提交
   
   谢谢提醒。
   我一直都是内网开发，没怎么用过github，我回去研究下吧。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #648: [ISSUE #646] fix responseTable memory leaks

Posted by GitBox <gi...@apache.org>.

wenfengwang commented on pull request #648:
URL: https://github.com/apache/rocketmq-client-go/pull/648#issuecomment-856558932


   @NAND86  CI挂了，能再看看吗


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org