You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/02 10:12:35 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2167: Thrift.csproj: Stop writing AssemblyAttributes.cs to /tmp
emmenlau opened a new pull request #2167:
URL: https://github.com/apache/thrift/pull/2167
The netstd build writes so-called `TargetFrameworkMonikerAssemblyAttributes` files to `/tmp`. These files can be left behind, and they do not feature a build-specific or user-specific name. This can be a problem in a multi-user environment, because the files block future builds by other users (that can not overwrite the files).
This PR adds a workaround by placing the files into the build directory rather than the `/tmp` directory. There should be no negative effects, other than a new, extra line in the `Thrift.csproj` settings.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2167: Thrift.csproj: Stop writing AssemblyAttributes.cs to /tmp
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2167:
URL: https://github.com/apache/thrift/pull/2167#issuecomment-641587017
Could you force-push? There were a bunch of (probably unrelated) curl errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2167: Thrift.csproj: Stop writing AssemblyAttributes.cs to /tmp
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2167:
URL: https://github.com/apache/thrift/pull/2167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org