[jira] [Commented] (AMBARI-24763) Infra Solr upgrade (2.7.x): ValueError: invalid literal for float():

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-24763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646867#comment-16646867 ] 

ASF GitHub Bot commented on AMBARI-24763:
-----------------------------------------

oleewere opened a new pull request #5: AMBARI-24763. Infra Solr upgrade (2.7.x): ValueError: invalid literal for float():
URL: https://github.com/apache/ambari-infra/pull/5
 
 
   ## What changes were proposed in this pull request?
   in some cases (probably system environment problem? ), invalid float literals can be invalid. fixing that by using locale
   
   ## How was this patch tested?
   manually by someone else
   
   Please review @zeroflag @adoroszlai @g-boros @kasakrisz @swagle 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Infra Solr upgrade (2.7.x): ValueError: invalid literal for float():
> --------------------------------------------------------------------
>
>                 Key: AMBARI-24763
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24763
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Olivér Szabó
>            Assignee: Olivér Szabó
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 2.7.3
>
>
> exception:
> {code:java}
> File "/usr/lib/ambari-infra-solr-client/migrationHelper.py", line 951, in parse_size 
> return int(float(number)*units[unit]) 
> ValueError: invalid literal for float(): 1,013.88 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)