Re: [PR] [BEAM-6394] Add support to write protobuf data using ProtoParquetReader [beam]

["cyberbeam524 (via GitHub)" <gi...@apache.org>]

cyberbeam524 commented on PR #34063:
URL: https://github.com/apache/beam/pull/34063#issuecomment-2831098101

   @Abacn Added the following changes according to your comments. Could you please take a look? Thank you!
   - Added ReaderFormat enum to ParquetIO.ReadFiles
   - Replaced boolean `useProtoReader` flag with a public `ReaderFormat` enum (AVRO, PROTO)
   - Default to `ReaderFormat.AVRO` for backward compatibility
   - Added `withAvroReader()` and `withProtoReader()` builder methods
   - Refactored`SplitReadFn` to `switch` on `ReaderFormat` and dispatch to Avro or Proto reader
   - Removed`"parquet.proto.ignore.unknown.fields"` setting from the default path
   - Update DisplayData to emit `readerFormat.name()`
   - Update unit tests to assert on `ReaderFormat` and display data accordingly
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org