You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Darj <zi...@alagazam.net> on 2009/04/24 20:36:11 UTC
[PATCH] windows-WiX installer updated for 1.6.x
Patch for the packages/windows-WiX installer to handle the fact that there are no binaries built for Apache 2.0 bindings
RE: Re: [PATCH] windows-WiX installer updated for 1.6.x
Posted by David Darj <zi...@alagazam.net>.
Hi.
It seems that Troy Simpson have returned and done almost the same changes to the installer.
Therefore I think this case can be closed and forgotten.
/David
> Normally we can file the issue first and add the log message later...
>
> But for a 100KB patch? I think the first issue is the reduce it to
> managable size. Looking into it, one of the hunks has two 37K-character
> lines. That consist mainly of changing some absolute local paths (which
> shouldn't be versioned anyway). Perhaps we need to refactor that file (to
> wrap it and remove the absolute local paths) first.
>
> Gavin Baumanis wrote on Sat, 30 May 2009 at 12:38 +1000:
> > Hi David,
> >
> > Just following up on this patch submission of yours.
> > I was abut to log it into the issue tracker when I realised there
> > wasn't "really" a log message for the patch.
> > I was going to use your single line of text from your original mail,
> > but thought I would check if you felt that was sufficient?
> >
> > Please refer to;
> > http://subversion.tigris.org/hacking.html#patches
> >
> > for the patch submission guidelines - and of course feel free to ask
> > for any help you might need.
> >
> >
> > Gavin.
> >
> >
> > On 25/04/2009, at 6:36 AM, David Darj wrote:
> >
> > > Patch for the packages/windows-WiX installer to handle the fact that
> > > there are no binaries built for Apache 2.0 bindings<Svn-
> > > WindowsWiX-1.6.diff>
> >
> > ------------------------------------------------------
> > http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2357047
> >
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2365416
Re: [PATCH] windows-WiX installer updated for 1.6.x
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Normally we can file the issue first and add the log message later...
But for a 100KB patch? I think the first issue is the reduce it to
managable size. Looking into it, one of the hunks has two 37K-character
lines. That consist mainly of changing some absolute local paths (which
shouldn't be versioned anyway). Perhaps we need to refactor that file (to
wrap it and remove the absolute local paths) first.
Gavin Baumanis wrote on Sat, 30 May 2009 at 12:38 +1000:
> Hi David,
>
> Just following up on this patch submission of yours.
> I was abut to log it into the issue tracker when I realised there
> wasn't "really" a log message for the patch.
> I was going to use your single line of text from your original mail,
> but thought I would check if you felt that was sufficient?
>
> Please refer to;
> http://subversion.tigris.org/hacking.html#patches
>
> for the patch submission guidelines - and of course feel free to ask
> for any help you might need.
>
>
> Gavin.
>
>
> On 25/04/2009, at 6:36 AM, David Darj wrote:
>
> > Patch for the packages/windows-WiX installer to handle the fact that
> > there are no binaries built for Apache 2.0 bindings<Svn-
> > WindowsWiX-1.6.diff>
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2357047
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2357077
Re: [PATCH] windows-WiX installer updated for 1.6.x
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi David,
Just following up on this patch submission of yours.
I was abut to log it into the issue tracker when I realised there
wasn't "really" a log message for the patch.
I was going to use your single line of text from your original mail,
but thought I would check if you felt that was sufficient?
Please refer to;
http://subversion.tigris.org/hacking.html#patches
for the patch submission guidelines - and of course feel free to ask
for any help you might need.
Gavin.
On 25/04/2009, at 6:36 AM, David Darj wrote:
> Patch for the packages/windows-WiX installer to handle the fact that
> there are no binaries built for Apache 2.0 bindings<Svn-
> WindowsWiX-1.6.diff>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2357047
Re: [PATCH] windows-WiX installer updated for 1.6.x
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Ping. This patch submission has received no comments.
Gavin.
On 25/04/2009, at 6:36 AM, David Darj wrote:
> Patch for the packages/windows-WiX installer to handle the fact that
> there are no binaries built for Apache 2.0 bindings<Svn-
> WindowsWiX-1.6.diff>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2353093
Re: [PATCH] windows-WiX installer updated for 1.6.x
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi David,
I have obviously misread it, sorry.
I was sure one of the posting read that it was for Apache 2.2 and the
other for 2.0
Anyway, I am not an SVN Committer and so (personally) cannot commit
the patch for you.
My Role as Patch Manager is to ensure that patch submissions by non-
committers don't slip through the cracks!
Thus the email to bring it back to the top of everyone's mail client
to try and get some new interest / enthusiasm for the submission.
Gavin.
On 02/05/2009, at 12:00 AM, David Darj wrote:
> Hi Gavin.
>
> The two postings contains the same patch file.
> I thought it was best to post it in a seperate thread with the [PATCH]
> prefix for clearity.
>
> Great if you could commit this patch so it'll be ready for the
> upcoming
> 1.6.2 release.
>
> Thanks
> /David
>
> Gavin Baumanis wrote:
>> Hi David,
>>
>> I was just about to do the weekly pings for patches that were
>> submitted, when I came across this one from you.
>>
>> I just wanted to know if this new patch supersedes the previous one
>> you write for apache 2.2?
>> I.e does the new patch incorporate the changes you made in the
>> previous one too - or are they separate?
>>
>> Here is a link to the original,
>> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=1763363&dsForumId=462
>>
>> Gavin.
>>
>> On 25/04/2009, at 6:36 AM, David Darj wrote:
>>
>>
>>> Patch for the packages/windows-WiX installer to handle the fact that
>>> there are no binaries built for Apache 2.0 bindings<Svn-
>>> WindowsWiX-1.6.diff>
>>>
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2012588
>>
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2014988
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2022643
Re: [PATCH] windows-WiX installer updated for 1.6.x
Posted by David Darj <zi...@alagazam.net>.
Hi Gavin.
The two postings contains the same patch file.
I thought it was best to post it in a seperate thread with the [PATCH]
prefix for clearity.
Great if you could commit this patch so it'll be ready for the upcoming
1.6.2 release.
Thanks
/David
Gavin Baumanis wrote:
> Hi David,
>
> I was just about to do the weekly pings for patches that were
> submitted, when I came across this one from you.
>
> I just wanted to know if this new patch supersedes the previous one
> you write for apache 2.2?
> I.e does the new patch incorporate the changes you made in the
> previous one too - or are they separate?
>
> Here is a link to the original,
> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=1763363&dsForumId=462
>
> Gavin.
>
> On 25/04/2009, at 6:36 AM, David Darj wrote:
>
>
>> Patch for the packages/windows-WiX installer to handle the fact that
>> there are no binaries built for Apache 2.0 bindings<Svn-
>> WindowsWiX-1.6.diff>
>>
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2012588
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2014988
Re: [PATCH] windows-WiX installer updated for 1.6.x
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi David,
I was just about to do the weekly pings for patches that were
submitted, when I came across this one from you.
I just wanted to know if this new patch supersedes the previous one
you write for apache 2.2?
I.e does the new patch incorporate the changes you made in the
previous one too - or are they separate?
Here is a link to the original,
http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=1763363&dsForumId=462
Gavin.
On 25/04/2009, at 6:36 AM, David Darj wrote:
> Patch for the packages/windows-WiX installer to handle the fact that
> there are no binaries built for Apache 2.0 bindings<Svn-
> WindowsWiX-1.6.diff>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2012588