You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/12 16:31:08 UTC
[PR] [SPARK-58746][INFRA] Remove a dead lsof workaround and fix stale references in release tooling [spark]
uros-b opened a new pull request, #57972:
URL: https://github.com/apache/spark/pull/57972
### What changes were proposed in this pull request?
Three fixes to developer and release tooling:
- `dev/create-release/release-build.sh`: removes the dead `lsof` band-aid block, and fixes a typo in the usage help (`reposiotry` to `repository`).
- `.github/PULL_REQUEST_TEMPLATE`: updates the `ConfigEntry.scala` path to its current location under `common/utils`.
### Why are the changes needed?
The `lsof` block assigns `$LSOF` and probes for the binary, but `$LSOF` is never used anywhere in the script or in anything it sources or that calls it, so the SPARK-22377 workaround has had no effect since the Jenkins machines it targeted were retired. The PR template points contributors at `core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala`, which no longer exists; the file now lives under `common/utils`.
### Does this PR introduce _any_ user-facing change?
No. Developer and release tooling only.
### How was this patch tested?
No functional change. `release-build.sh` still parses (`bash -n`), `$LSOF` was confirmed to have no reference outside the removed block (including in `release-util.sh` and `do-release.sh`), and the corrected `ConfigEntry.scala` path exists on master while the old one does not.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58746][INFRA] Remove a dead lsof workaround and fix stale references in release tooling [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57972:
URL: https://github.com/apache/spark/pull/57972#issuecomment-5282505303
Thank you @HyukjinKwon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58746][INFRA] Remove a dead lsof workaround and fix stale references in release tooling [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57972:
URL: https://github.com/apache/spark/pull/57972#issuecomment-5282521490
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/6b6e9109d62bed8eb94e1b1829ef0d0014604cd9
- merged into branch-4.x https://github.com/apache/spark/commit/f9cb284ac7ae3e5d4e4d24f1580d110d51ca5163
- merged into branch-4.3 https://github.com/apache/spark/commit/7681d2e6d628eeeda2ec7441644fce84f2302627
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58746][INFRA] Remove a dead lsof workaround and fix stale references in release tooling [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57972: [SPARK-58746][INFRA] Remove a dead lsof workaround and fix stale references in release tooling
URL: https://github.com/apache/spark/pull/57972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org