[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

["abeltian (Code Review)" <ge...@cloudera.org>]

abeltian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 )

Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16412/14/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

http://gerrit.cloudera.org:8080/#/c/16412/14/be/src/scheduling/admission-controller.cc@1155
PS14, Line 1155:     if (!queued) queue_nodes_.erase(request.query_id);
We can get a memory leak here.

I think you can use if (!*queued) at L1155.



-- 
To view, visit http://gerrit.cloudera.org:8080/16412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I594fc593a27b24b6952e381a9bc1a9a5c6b757ae
Gerrit-Change-Number: 16412
Gerrit-PatchSet: 14
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 01:46:10 +0000
Gerrit-HasComments: Yes