You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/12 20:37:38 UTC
[GitHub] [superset] cccs-RyanK commented on a diff in pull request #22084: feat: Select all for synchronous select
cccs-RyanK commented on code in PR #22084:
URL: https://github.com/apache/superset/pull/22084#discussion_r1068630994
##########
superset-frontend/src/components/Select/AsyncSelect.tsx:
##########
@@ -527,7 +527,7 @@ const AsyncSelect = forwardRef(
)
}
oneLine={oneLine}
- tagRender={oneLine ? oneLineTagRender : undefined}
+ tagRender={customTagRender}
Review Comment:
yes `customTagRender` is the same as `oneLineTagRender`. It has the same behaviour except it does not render the select all tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org