You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Marcus Schulte (JIRA)" <ta...@jakarta.apache.org> on 2006/08/18 08:26:13 UTC
[jira] Created: (TAPESTRY-1071) Client-side number validation does
not work
Client-side number validation does not work
-------------------------------------------
Key: TAPESTRY-1071
URL: http://issues.apache.org/jira/browse/TAPESTRY-1071
Project: Tapestry
Issue Type: Bug
Components: Framework
Affects Versions: 4.1.1
Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
Reporter: Marcus Schulte
Specifiying no special pattern for the NumberTranslator leads to:
- client calls dojo number validation with groupingChar=' and any number of decimal places
- if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1071?page=all ]
Jesse Kuhnert reassigned TAPESTRY-1071:
---------------------------------------
Assignee: Jesse Kuhnert
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1071) Client-side number validation
does not work
Posted by "Gary Mak (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492571 ]
Gary Mak commented on TAPESTRY-1071:
------------------------------------
Why has this fix been rolled back since Dec 10 2006? Now this error happens again for Tapestry 4.1.1 and 4.1.2-SNAPSHOT.
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1071?page=all ]
Jesse Kuhnert resolved TAPESTRY-1071.
-------------------------------------
Fix Version/s: 4.1.1
Resolution: Fixed
Fixed. Sorry about that. Should've been caught earlier.
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1071) Client-side number validation
does not work
Posted by "Marcus Schulte (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1071?page=comments#action_12429213 ]
Marcus Schulte commented on TAPESTRY-1071:
------------------------------------------
Should be a simple fix in NumberTranslator:
The defaultFormat is "#", which is good.
Then, in renderContribution, the grouping separator is *always* passed to dojo in the JSON object (line 134).
I think, passing the grouping separator only if format.isGroupingUsed() returns true, should resolve the issue
Thus, instead of
+ "separator:" + JSONObject.quote(format.getDecimalFormatSymbols().getGroupingSeparator())
line 134 should probably read
+ ( format.isGroupingUsed ? "separator:" + JSONObject.quote(format.getDecimalFormatSymbols().getGroupingSeparator()) : "")
So, it's a trivial buggy after all.
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Reopened: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Marcus Schulte (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcus Schulte reopened TAPESTRY-1071:
--------------------------------------
regression
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Gary Mak (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Mak updated TAPESTRY-1071:
-------------------------------
Affects Version/s: (was: 4.1.1)
4.1.2
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Kuhnert resolved TAPESTRY-1071.
-------------------------------------
Resolution: Fixed
I think I fixed this bug within the tapestry provided version of dojo itself because that's where it is. ...Using separator:"" should be enough but the built in regexp logic in dojo blows up because it doesn't take this into account....So either way it should work "as is" right now.....but I guess you can give it a go yourself when you get back ;)
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.2
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Kuhnert resolved TAPESTRY-1071.
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 4.1.1)
4.1.2
Re-fixed as per Marcus's instructions. (thanks)
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.2
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Gary Mak (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Mak updated TAPESTRY-1071:
-------------------------------
Affects Version/s: (was: 4.1.2)
4.1.1
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.1
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Reopened: (TAPESTRY-1071) Client-side number validation does
not work
Posted by "Marcus Schulte (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcus Schulte reopened TAPESTRY-1071:
--------------------------------------
With the use of dojo.i18n.number.isReal, it is not sufficient anymore to just omit the grouping specs, they must be explicitly set to "no-grouping-values".
Thus, NumberValidator needs
...
String grouping;
if (format.isGroupingUsed()) {
grouping = ",separator:" + JSONObject.quote(format.getDecimalFormatSymbols().getGroupingSeparator());
grouping += ",groupSize:" + format.getGroupingSize();
} else grouping = ",separator:'',groupSize:0";
...
An equivalent fix needs to be made to the comparison-validators which call tapestry.form.validation.greaterThan/lessOrEqual.
> Client-side number validation does not work
> -------------------------------------------
>
> Key: TAPESTRY-1071
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1071
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1.1
> Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
> Reporter: Marcus Schulte
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.2
>
>
> Specifiying no special pattern for the NumberTranslator leads to:
> - client calls dojo number validation with groupingChar=' and any number of decimal places
> - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org