[GitHub] [nifi] mattyb149 commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327



##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
 
         try {
             new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
-                    out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+                    out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);

Review comment:
       I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org