You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "swamirishi (via GitHub)" <gi...@apache.org> on 2025/07/10 11:48:18 UTC
[PR] HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush [ozone]
swamirishi opened a new pull request, #8779:
URL: https://github.com/apache/ozone/pull/8779
## What changes were proposed in this pull request?
As part of the OM Double Buffer flush, an entry corresponding to each transaction flushed should be added to the flushedTransactionsTable in OM rocksdb.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13418
## How was this patch tested?
Additional unit test to be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8779:
URL: https://github.com/apache/ozone/pull/8779#issuecomment-3057508202
Please wait for the other PR to be merged before opening the dependent one. PRs should not be sitting in the queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi commented on code in PR #8779:
URL: https://github.com/apache/ozone/pull/8779#discussion_r2641773095
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -378,8 +389,11 @@ private String addToBatch(Queue<Entry> buffer, BatchOperation batchOperation) {
lastTraceId = omResponse.getTraceID();
try {
- addToBatchWithTrace(omResponse,
- () -> response.checkAndUpdateDB(omMetadataManager, batchOperation));
+ addToBatchWithTrace(omResponse, () -> {
+ response.checkAndUpdateDB(omMetadataManager, batchOperation);
+ omMetadataManager.getFlushedTransactionsTable().putWithBatch(batchOperation, entry.termIndex.getIndex(),
Review Comment:
flush as part of double buffer batch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi closed pull request #8779: HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush
URL: https://github.com/apache/ozone/pull/8779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi commented on code in PR #8779:
URL: https://github.com/apache/ozone/pull/8779#discussion_r2510853726
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -334,9 +344,9 @@ private void flushBatch(Queue<Entry> buffer) throws IOException {
try (BatchOperation batchOperation = omMetadataManager.getStore()
.initBatchOperation()) {
-
String lastTraceId = addToBatch(buffer, batchOperation);
-
+ omMetadataManager.getFlushedTransactionsTable().deleteRangeWithBatch(batchOperation, 0L,
+ Math.max(lastTransaction.getIndex() - maxFlushedTransactionGap, 0L));
Review Comment:
This can be used in event notification design as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13418. Add Flushed Transaction Info as part of OM Double Buffer Flush [ozone]
Posted by "swamirishi (via GitHub)" <gi...@apache.org>.
swamirishi commented on code in PR #8779:
URL: https://github.com/apache/ozone/pull/8779#discussion_r2510853726
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -334,9 +344,9 @@ private void flushBatch(Queue<Entry> buffer) throws IOException {
try (BatchOperation batchOperation = omMetadataManager.getStore()
.initBatchOperation()) {
-
String lastTraceId = addToBatch(buffer, batchOperation);
-
+ omMetadataManager.getFlushedTransactionsTable().deleteRangeWithBatch(batchOperation, 0L,
+ Math.max(lastTransaction.getIndex() - maxFlushedTransactionGap, 0L));
Review Comment:
This can be used in even notification design as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org