You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "deepakpanda93 (via GitHub)" <gi...@apache.org> on 2025/09/19 14:28:32 UTC
[PR] (feat) Add support for jupyter notebooks in docker [hudi]
deepakpanda93 opened a new pull request, #13939:
URL: https://github.com/apache/hudi/pull/13939
### Describe the issue this Pull Request addresses
This PR adds support for running JupyterLab within the existing Docker environment.
### Summary and Changelog
- Installed jupyterlab and required Python packages inside the Docker image
- Exposed port 8888 for notebook access
- Added a launch command to run JupyterLab server within the container
- Updated Docker CMD/entrypoint to support notebook environments
### Impact
None
### Risk Level
none
### Documentation Update
a quick-start section or link in documentation could be added to show how to use notebooks via Docker
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (feat) Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3312706950
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3347104240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
}, {
"hash" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847",
"triggerID" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"triggerType" : "PUSH"
}, {
"hash" : "c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8926",
"triggerID" : "c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8926)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #13939:
URL: https://github.com/apache/hudi/pull/13939#discussion_r2431127968
##########
docker/compose/notebooks/utils.ipynb:
##########
@@ -0,0 +1,223 @@
+{
+ "cells": [
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "3c22eccc-8655-4b87-bc0d-cd5a068b889b",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "# Licensed to the Apache Software Foundation (ASF) under one\n",
+ "# or more contributor license agreements. See the NOTICE file\n",
+ "# distributed with this work for additional information\n",
+ "# regarding copyright ownership. The ASF licenses this file\n",
+ "# to you under the Apache License, Version 2.0 (the\n",
+ "# \"License\"); you may not use this file except in compliance\n",
+ "# with the License. You may obtain a copy of the License at\n",
+ "#\n",
+ "# http://www.apache.org/licenses/LICENSE-2.0\n",
+ "#\n",
+ "# Unless required by applicable law or agreed to in writing, software\n",
+ "# distributed under the License is distributed on an \"AS IS\" BASIS,\n",
+ "# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n",
+ "# See the License for the specific language governing permissions and\n",
+ "# limitations under the License."
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 1,
+ "id": "f8bbcda9-7b8a-4415-8915-acadcfa07660",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "import os\n",
+ "from pyspark.sql import SparkSession"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "c44b9eca-63e2-468a-ba86-8113533b4d15",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "HUDI_JAR = os.environ.get(\"HUDI_SPARK_BUNDLE\")\n",
+ "if not HUDI_JAR:\n",
+ " raise EnvironmentError(\"HUDI_SPARK_BUNDLE environment variable not set\")\n",
+ "\n",
+ "HADOOP_S3_JAR = \"/opt/spark/jars/hadoop-aws-3.3.4.jar,/opt/spark/jars/aws-java-sdk-bundle-1.12.734.jar\"\n",
+ "\n",
+ "ALL_JARS = f\"{HUDI_JAR},{HADOOP_S3_JAR}\""
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 3,
+ "id": "7f104543-3374-4c78-b666-bf44f3be962c",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "def get_spark_session(app_name=\"Hudi-Notebooks\"):\n",
Review Comment:
we should avoid putting redundant code in the codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3337508617
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2dd97b1e8a7e0620ec210e417e61dc2e00227b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3312929806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653)
* 48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3313261412
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3338660763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
}, {
"hash" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847",
"triggerID" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2dd97b1e8a7e0620ec210e417e61dc2e00227b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840)
* 189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on code in PR #13939:
URL: https://github.com/apache/hudi/pull/13939#discussion_r2382728147
##########
docker/compose/notebooks/utils.ipynb:
##########
@@ -0,0 +1,223 @@
+{
+ "cells": [
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "3c22eccc-8655-4b87-bc0d-cd5a068b889b",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "# Licensed to the Apache Software Foundation (ASF) under one\n",
+ "# or more contributor license agreements. See the NOTICE file\n",
+ "# distributed with this work for additional information\n",
+ "# regarding copyright ownership. The ASF licenses this file\n",
+ "# to you under the Apache License, Version 2.0 (the\n",
+ "# \"License\"); you may not use this file except in compliance\n",
+ "# with the License. You may obtain a copy of the License at\n",
+ "#\n",
+ "# http://www.apache.org/licenses/LICENSE-2.0\n",
+ "#\n",
+ "# Unless required by applicable law or agreed to in writing, software\n",
+ "# distributed under the License is distributed on an \"AS IS\" BASIS,\n",
+ "# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n",
+ "# See the License for the specific language governing permissions and\n",
+ "# limitations under the License."
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 1,
+ "id": "f8bbcda9-7b8a-4415-8915-acadcfa07660",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "import os\n",
+ "from pyspark.sql import SparkSession"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "c44b9eca-63e2-468a-ba86-8113533b4d15",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "HUDI_JAR = os.environ.get(\"HUDI_SPARK_BUNDLE\")\n",
+ "if not HUDI_JAR:\n",
+ " raise EnvironmentError(\"HUDI_SPARK_BUNDLE environment variable not set\")\n",
+ "\n",
+ "HADOOP_S3_JAR = \"/opt/spark/jars/hadoop-aws-3.3.4.jar,/opt/spark/jars/aws-java-sdk-bundle-1.12.734.jar\"\n",
+ "\n",
+ "ALL_JARS = f\"{HUDI_JAR},{HADOOP_S3_JAR}\""
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 3,
+ "id": "7f104543-3374-4c78-b666-bf44f3be962c",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "def get_spark_session(app_name=\"Hudi-Notebooks\"):\n",
Review Comment:
Created a file with utils.py and used the same in all the notebooks as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3312936120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653)
* 48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on code in PR #13939:
URL: https://github.com/apache/hudi/pull/13939#discussion_r2381379176
##########
docker/hoodie/hadoop/sparkmaster/entrypoint.sh:
##########
@@ -0,0 +1,24 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Start the spark master in the background
Review Comment:
Added !
##########
docker/hoodie/hadoop/sparkmaster/Dockerfile:
##########
@@ -20,12 +20,27 @@ ARG HIVE_VERSION=3.1.3
ARG SPARK_VERSION=3.5.3
FROM apachehudi/hudi-hadoop_${HADOOP_VERSION}-hive_${HIVE_VERSION}-sparkbase_${SPARK_VERSION}
-COPY master.sh /opt/spark
+#COPY master.sh /opt/spark
+#RUN chmod +x /opt/spark/master.sh
+
+#COPY jupyter.sh /opt/spark
+#RUN chmod +x /opt/spark/jupyter.sh
+
+#COPY entrypoint.sh /opt/spark
+#RUN chmod +x /opt/spark/entrypoint.sh
Review Comment:
Cleaned !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3339019842
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
}, {
"hash" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847",
"triggerID" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3337169145
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656)
* da2dd97b1e8a7e0620ec210e417e61dc2e00227b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3588009029
> @deepakpanda93 @xushiyan is this PR still needed?
Following up on this @deepakpanda93 @xushiyan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (feat) Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3312443274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3346706779
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
}, {
"hash" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847",
"triggerID" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"triggerType" : "PUSH"
}, {
"hash" : "c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847)
* c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3337164353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656)
* da2dd97b1e8a7e0620ec210e417e61dc2e00227b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3338652601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
}, {
"hash" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2dd97b1e8a7e0620ec210e417e61dc2e00227b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840)
* 189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #13939:
URL: https://github.com/apache/hudi/pull/13939#discussion_r2380896986
##########
docker/compose/notebooks/utils.ipynb:
##########
@@ -0,0 +1,223 @@
+{
+ "cells": [
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "3c22eccc-8655-4b87-bc0d-cd5a068b889b",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "# Licensed to the Apache Software Foundation (ASF) under one\n",
+ "# or more contributor license agreements. See the NOTICE file\n",
+ "# distributed with this work for additional information\n",
+ "# regarding copyright ownership. The ASF licenses this file\n",
+ "# to you under the Apache License, Version 2.0 (the\n",
+ "# \"License\"); you may not use this file except in compliance\n",
+ "# with the License. You may obtain a copy of the License at\n",
+ "#\n",
+ "# http://www.apache.org/licenses/LICENSE-2.0\n",
+ "#\n",
+ "# Unless required by applicable law or agreed to in writing, software\n",
+ "# distributed under the License is distributed on an \"AS IS\" BASIS,\n",
+ "# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n",
+ "# See the License for the specific language governing permissions and\n",
+ "# limitations under the License."
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 1,
+ "id": "f8bbcda9-7b8a-4415-8915-acadcfa07660",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "import os\n",
+ "from pyspark.sql import SparkSession"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "c44b9eca-63e2-468a-ba86-8113533b4d15",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "HUDI_JAR = os.environ.get(\"HUDI_SPARK_BUNDLE\")\n",
+ "if not HUDI_JAR:\n",
+ " raise EnvironmentError(\"HUDI_SPARK_BUNDLE environment variable not set\")\n",
+ "\n",
+ "HADOOP_S3_JAR = \"/opt/spark/jars/hadoop-aws-3.3.4.jar,/opt/spark/jars/aws-java-sdk-bundle-1.12.734.jar\"\n",
+ "\n",
+ "ALL_JARS = f\"{HUDI_JAR},{HADOOP_S3_JAR}\""
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 3,
+ "id": "7f104543-3374-4c78-b666-bf44f3be962c",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "def get_spark_session(app_name=\"Hudi-Notebooks\"):\n",
Review Comment:
utils need to be put in a notebook? they're supposed to be just imported by other notebooks and can live in .py files?
##########
docker/hoodie/hadoop/sparkmaster/entrypoint.sh:
##########
@@ -0,0 +1,24 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Start the spark master in the background
Review Comment:
add comments before this explain who use this script
##########
docker/hoodie/hadoop/sparkmaster/Dockerfile:
##########
@@ -20,12 +20,27 @@ ARG HIVE_VERSION=3.1.3
ARG SPARK_VERSION=3.5.3
FROM apachehudi/hudi-hadoop_${HADOOP_VERSION}-hive_${HIVE_VERSION}-sparkbase_${SPARK_VERSION}
-COPY master.sh /opt/spark
+#COPY master.sh /opt/spark
+#RUN chmod +x /opt/spark/master.sh
+
+#COPY jupyter.sh /opt/spark
+#RUN chmod +x /opt/spark/jupyter.sh
+
+#COPY entrypoint.sh /opt/spark
+#RUN chmod +x /opt/spark/entrypoint.sh
Review Comment:
do not leave commented code. either remove or keep them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #13939:
URL: https://github.com/apache/hudi/pull/13939#discussion_r2431122540
##########
docker/compose/notebooks/utils.ipynb:
##########
@@ -0,0 +1,223 @@
+{
+ "cells": [
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "3c22eccc-8655-4b87-bc0d-cd5a068b889b",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "# Licensed to the Apache Software Foundation (ASF) under one\n",
+ "# or more contributor license agreements. See the NOTICE file\n",
+ "# distributed with this work for additional information\n",
+ "# regarding copyright ownership. The ASF licenses this file\n",
+ "# to you under the Apache License, Version 2.0 (the\n",
+ "# \"License\"); you may not use this file except in compliance\n",
+ "# with the License. You may obtain a copy of the License at\n",
+ "#\n",
+ "# http://www.apache.org/licenses/LICENSE-2.0\n",
+ "#\n",
+ "# Unless required by applicable law or agreed to in writing, software\n",
+ "# distributed under the License is distributed on an \"AS IS\" BASIS,\n",
+ "# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n",
+ "# See the License for the specific language governing permissions and\n",
+ "# limitations under the License."
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 1,
+ "id": "f8bbcda9-7b8a-4415-8915-acadcfa07660",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "import os\n",
+ "from pyspark.sql import SparkSession"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "c44b9eca-63e2-468a-ba86-8113533b4d15",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "HUDI_JAR = os.environ.get(\"HUDI_SPARK_BUNDLE\")\n",
+ "if not HUDI_JAR:\n",
+ " raise EnvironmentError(\"HUDI_SPARK_BUNDLE environment variable not set\")\n",
+ "\n",
+ "HADOOP_S3_JAR = \"/opt/spark/jars/hadoop-aws-3.3.4.jar,/opt/spark/jars/aws-java-sdk-bundle-1.12.734.jar\"\n",
+ "\n",
+ "ALL_JARS = f\"{HUDI_JAR},{HADOOP_S3_JAR}\""
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 3,
+ "id": "7f104543-3374-4c78-b666-bf44f3be962c",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "def get_spark_session(app_name=\"Hudi-Notebooks\"):\n",
Review Comment:
so with `utils.py`, why we still need `utils.ipynb` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] (feat) Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3312435470
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3346716162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8653",
"triggerID" : "2b09b96b9bf3fe84cc96a758f14d5b988b08a5dd",
"triggerType" : "PUSH"
}, {
"hash" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8656",
"triggerID" : "48cd1f9ae46ac2b7cb58b93ed9410c8e0433f92a",
"triggerType" : "PUSH"
}, {
"hash" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8840",
"triggerID" : "da2dd97b1e8a7e0620ec210e417e61dc2e00227b",
"triggerType" : "PUSH"
}, {
"hash" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847",
"triggerID" : "189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b",
"triggerType" : "PUSH"
}, {
"hash" : "c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8926",
"triggerID" : "c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 189ef21c0edd1b1507d8b7c7ea0bb503f2e6ba1b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8847)
* c50eb5e6cab46ac0bb5df4d0ea759f796983d1f6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8926)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on code in PR #13939:
URL: https://github.com/apache/hudi/pull/13939#discussion_r2381454072
##########
docker/compose/notebooks/utils.ipynb:
##########
@@ -0,0 +1,223 @@
+{
+ "cells": [
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "3c22eccc-8655-4b87-bc0d-cd5a068b889b",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "# Licensed to the Apache Software Foundation (ASF) under one\n",
+ "# or more contributor license agreements. See the NOTICE file\n",
+ "# distributed with this work for additional information\n",
+ "# regarding copyright ownership. The ASF licenses this file\n",
+ "# to you under the Apache License, Version 2.0 (the\n",
+ "# \"License\"); you may not use this file except in compliance\n",
+ "# with the License. You may obtain a copy of the License at\n",
+ "#\n",
+ "# http://www.apache.org/licenses/LICENSE-2.0\n",
+ "#\n",
+ "# Unless required by applicable law or agreed to in writing, software\n",
+ "# distributed under the License is distributed on an \"AS IS\" BASIS,\n",
+ "# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n",
+ "# See the License for the specific language governing permissions and\n",
+ "# limitations under the License."
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 1,
+ "id": "f8bbcda9-7b8a-4415-8915-acadcfa07660",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "import os\n",
+ "from pyspark.sql import SparkSession"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "c44b9eca-63e2-468a-ba86-8113533b4d15",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "HUDI_JAR = os.environ.get(\"HUDI_SPARK_BUNDLE\")\n",
+ "if not HUDI_JAR:\n",
+ " raise EnvironmentError(\"HUDI_SPARK_BUNDLE environment variable not set\")\n",
+ "\n",
+ "HADOOP_S3_JAR = \"/opt/spark/jars/hadoop-aws-3.3.4.jar,/opt/spark/jars/aws-java-sdk-bundle-1.12.734.jar\"\n",
+ "\n",
+ "ALL_JARS = f\"{HUDI_JAR},{HADOOP_S3_JAR}\""
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 3,
+ "id": "7f104543-3374-4c78-b666-bf44f3be962c",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "def get_spark_session(app_name=\"Hudi-Notebooks\"):\n",
Review Comment:
Putting static html pages in Hudi Wbsite is already in our plan. Once this PR is merged, then I will raise another docs PR to asf-site branch. I will update the same with a draft PR for your refernece.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on code in PR #13939:
URL: https://github.com/apache/hudi/pull/13939#discussion_r2381454072
##########
docker/compose/notebooks/utils.ipynb:
##########
@@ -0,0 +1,223 @@
+{
+ "cells": [
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "3c22eccc-8655-4b87-bc0d-cd5a068b889b",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "# Licensed to the Apache Software Foundation (ASF) under one\n",
+ "# or more contributor license agreements. See the NOTICE file\n",
+ "# distributed with this work for additional information\n",
+ "# regarding copyright ownership. The ASF licenses this file\n",
+ "# to you under the Apache License, Version 2.0 (the\n",
+ "# \"License\"); you may not use this file except in compliance\n",
+ "# with the License. You may obtain a copy of the License at\n",
+ "#\n",
+ "# http://www.apache.org/licenses/LICENSE-2.0\n",
+ "#\n",
+ "# Unless required by applicable law or agreed to in writing, software\n",
+ "# distributed under the License is distributed on an \"AS IS\" BASIS,\n",
+ "# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n",
+ "# See the License for the specific language governing permissions and\n",
+ "# limitations under the License."
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 1,
+ "id": "f8bbcda9-7b8a-4415-8915-acadcfa07660",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "import os\n",
+ "from pyspark.sql import SparkSession"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 2,
+ "id": "c44b9eca-63e2-468a-ba86-8113533b4d15",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "HUDI_JAR = os.environ.get(\"HUDI_SPARK_BUNDLE\")\n",
+ "if not HUDI_JAR:\n",
+ " raise EnvironmentError(\"HUDI_SPARK_BUNDLE environment variable not set\")\n",
+ "\n",
+ "HADOOP_S3_JAR = \"/opt/spark/jars/hadoop-aws-3.3.4.jar,/opt/spark/jars/aws-java-sdk-bundle-1.12.734.jar\"\n",
+ "\n",
+ "ALL_JARS = f\"{HUDI_JAR},{HADOOP_S3_JAR}\""
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 3,
+ "id": "7f104543-3374-4c78-b666-bf44f3be962c",
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "def get_spark_session(app_name=\"Hudi-Notebooks\"):\n",
Review Comment:
Putting static html pages in Hudi Wbsite is already in our plan. Once this PR is merged, then I will raise another docs PR to asf-site branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 closed pull request #13939: feat: Add support for jupyter notebooks in docker
URL: https://github.com/apache/hudi/pull/13939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add support for jupyter notebooks in docker [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on PR #13939:
URL: https://github.com/apache/hudi/pull/13939#issuecomment-3589841362
> > @deepakpanda93 @xushiyan is this PR still needed?
>
> Following up on this @deepakpanda93 @xushiyan
Hello @yihua
This feature has now been added in a separate Docker image used for notebook exploration, so we no longer need this PR. Closing it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org