You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org> on 2023/08/07 11:32:59 UTC
[GitHub] [incubator-uniffle] krishnaduttPanchagnula opened a new pull request, #1113: [#1096] test: added integration test to the pipeline
krishnaduttPanchagnula opened a new pull request, #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Added kubernetes Integration test CI to parallel.yaml
### Why are the changes needed?
Add kubernetes Integration test CI
Fix: #1096
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1285786813
##########
.github/workflows/parallel.yml:
##########
@@ -92,6 +92,11 @@ jobs:
if: ${{ failure() && inputs.summary != '' }}
run: ${{ inputs.summary }}
continue-on-error: true
+ - name: Run Integration Tests and Check test status
Review Comment:
> > You can see
> > https://github.com/apache/incubator-uniffle/blob/791e3e09e386391a3e000a9a9b005bc3f4fe8ab3/.github/workflows/build.yml#L86
>
> > This test should only be executed when we enable the profile of K8S.
>
> Moving this to the single.yaml should solve this right @jerqi ?
No. We should add this test to build.yml like
```
kubernetes:
.....
kubernetes-integration:
1. we should compile kubernetes operator first: mvn package -Pkubernetes -DskipTests
2. we run the shell to run the local shell tests
.....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293381923
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
+ set -e
Review Comment:
This is unnecessary. We have set the variable in the `start-e2e.sh`.
![Uploading 企业微信截图_2150d112-bb7b-48bf-b74d-ebb6e00900e4.png…]()
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
+ set -e
Review Comment:
This is unnecessary. We have set the variable in the `start-e2e.sh`.
![Uploading 企业微信截图_2150d112-bb7b-48bf-b74d-ebb6e00900e4.png…]()
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
+ set -e
Review Comment:
This is unnecessary. We have set the variable in the `start-e2e.sh`.
<img width="504" alt="企业微信截图_2150d112-bb7b-48bf-b74d-ebb6e00900e4" src="https://github.com/apache/incubator-uniffle/assets/8159038/1f273906-93c4-43c6-a762-32bdd107fa45">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293373832
##########
.github/workflows/build.yml:
##########
@@ -55,7 +60,7 @@ jobs:
java-11:
needs: [spotbugs] # delay execution
- name: 'compile'
+ name: 'compile-java11'
Review Comment:
Could we revert this change? We tell the difference.
<img width="295" alt="企业微信截图_2e4e5c92-42cb-4d98-acef-de26dade4153" src="https://github.com/apache/incubator-uniffle/assets/8159038/f9f85205-49b3-400e-8452-e8572dfad0e5">
##########
.github/workflows/build.yml:
##########
@@ -55,7 +60,7 @@ jobs:
java-11:
needs: [spotbugs] # delay execution
- name: 'compile'
+ name: 'compile-java11'
Review Comment:
Could we revert this change? We tell the difference.
<img width="295" alt="企业微信截图_2e4e5c92-42cb-4d98-acef-de26dade4153" src="https://github.com/apache/incubator-uniffle/assets/8159038/f9f85205-49b3-400e-8452-e8572dfad0e5">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1294449160
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,34 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ cd deploy/kubernetes/integration-test/e2e && ./start-e2e.sh
Review Comment:
There is a bash error. I will fix the issue of the bash.
<img width="626" alt="企业微信截图_0369d22e-ebce-47f2-8f55-46bf2a64edad" src="https://github.com/apache/incubator-uniffle/assets/8159038/0441ae12-5d74-4b72-9ae2-234301903833">
Let me use the command and I will merge this pr first.
```
# cd deploy/kubernetes/integration-test/e2e && sh start-e2e.sh
```
I will fix the script later.
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,34 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ cd deploy/kubernetes/integration-test/e2e && ./start-e2e.sh
Review Comment:
There is a bash error. I will fix the issue of the bash.
<img width="626" alt="企业微信截图_0369d22e-ebce-47f2-8f55-46bf2a64edad" src="https://github.com/apache/incubator-uniffle/assets/8159038/0441ae12-5d74-4b72-9ae2-234301903833">
Let me use the command and I will merge this pr first.
```
# cd deploy/kubernetes/integration-test/e2e && sh start-e2e.sh
```
I will fix the script later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1285771267
##########
.github/workflows/parallel.yml:
##########
@@ -92,6 +92,11 @@ jobs:
if: ${{ failure() && inputs.summary != '' }}
run: ${{ inputs.summary }}
continue-on-error: true
+ - name: Run Integration Tests and Check test status
Review Comment:
This test should only be executed when we enable the profile of K8S.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1285775465
##########
.github/workflows/parallel.yml:
##########
@@ -92,6 +92,11 @@ jobs:
if: ${{ failure() && inputs.summary != '' }}
run: ${{ inputs.summary }}
continue-on-error: true
+ - name: Run Integration Tests and Check test status
Review Comment:
You can see https://github.com/apache/incubator-uniffle/blob/791e3e09e386391a3e000a9a9b005bc3f4fe8ab3/.github/workflows/build.yml#L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1286022488
##########
.github/workflows/build.yml:
##########
@@ -91,3 +91,16 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
Review Comment:
My fault. If we add empty line, k8s ci will fail because of code style. So I add a blank in the comment. Now, we can run the k8s ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1285782278
##########
.github/workflows/parallel.yml:
##########
@@ -92,6 +92,11 @@ jobs:
if: ${{ failure() && inputs.summary != '' }}
run: ${{ inputs.summary }}
continue-on-error: true
+ - name: Run Integration Tests and Check test status
Review Comment:
> You can see
>
> https://github.com/apache/incubator-uniffle/blob/791e3e09e386391a3e000a9a9b005bc3f4fe8ab3/.github/workflows/build.yml#L86
> This test should only be executed when we enable the profile of K8S.
Moving this to the single.yaml should solve this right @jerqi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293609571
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
Review Comment:
> We don't need to change the permission. We can use the command to run the shell
>
> ```
> sh ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
> ```
The pipeline is unable to run the shell script, due to the permission error.
sh: 0: Can't open set-up-local-cluster.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293239038
##########
.github/workflows/build.yml:
##########
@@ -17,7 +17,32 @@
name: build
-on: [push, pull_request]
+on:
Review Comment:
Why do we remove `[push, pull_request]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1294449160
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,34 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ cd deploy/kubernetes/integration-test/e2e && ./start-e2e.sh
Review Comment:
There is a bash error. I will fix the issue of the bash.
<img width="626" alt="企业微信截图_0369d22e-ebce-47f2-8f55-46bf2a64edad" src="https://github.com/apache/incubator-uniffle/assets/8159038/0441ae12-5d74-4b72-9ae2-234301903833">
Let me use the command and I will merge this pr first.
```
# cd deploy/kubernetes/integration-test/e2e && sh start-e2e.sh
```
And then I will fix the script later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1286023302
##########
.github/workflows/build.yml:
##########
@@ -91,3 +91,16 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
Review Comment:
There still are some other errors. Could you fix them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#issuecomment-1667849254
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1113](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1113?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (72351e6) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/19e749633b2945549d20aaa3d2c32f6a644df55b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (19e7496) will **increase** coverage by `1.18%`.
> Report is 5 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1113 +/- ##
============================================
+ Coverage 54.08% 55.26% +1.18%
- Complexity 2542 2547 +5
============================================
Files 386 366 -20
Lines 21882 19555 -2327
Branches 1811 1815 +4
============================================
- Hits 11835 10808 -1027
+ Misses 9351 8119 -1232
+ Partials 696 628 -68
```
[see 29 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1113/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1287170471
##########
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go:
##########
@@ -359,7 +359,7 @@ type RemoteShuffleService struct {
//+kubebuilder:object:root=true
-// RemoteShuffleServiceList contains a list of RemoteShuffleService
+// RemoteShuffleServiceList contains a list of RemoteShuffleService
Review Comment:
This change will trigger k8s ci. So we shouldn't revert before we verify the correctness of k8s integration pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293335121
##########
.github/workflows/build.yml:
##########
@@ -17,7 +17,32 @@
name: build
-on: [push, pull_request]
+on:
Review Comment:
> Why do we remove `[push, pull_request]`?
We have to pass the inputs to the pipline for the pipeline to run. I am not sure if we can pass inputs for "on" key when we mention the push/pull action.
We can pass them under 'env' key though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] test: added integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1285855986
##########
.github/workflows/build.yml:
##########
@@ -91,3 +91,16 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
Review Comment:
These steps are also needed.
```
- name: Checkout project
uses: actions/checkout@v3
- name: Set up JDK ${{ inputs.java-version }}
uses: actions/setup-java@v3
with:
java-version: ${{ inputs.java-version }}
distribution: ${{ inputs.jdk-distro }}
- name: Cache local Maven repository
if: ${{ inputs.cache-key != '' }}
uses: actions/cache@v3
with:
path: ~/.m2/repository
key: mvn-${{ inputs.java-version }}-${{ inputs.cache-key }}-${{ hashFiles('**/pom.xml') }}
restore-keys: |
mvn-${{ inputs.java-version }}-${{ inputs.cache-key }}-
- name: Set up Go ${{ inputs.go-version }}
if: ${{ inputs.go-version != '' }}
uses: actions/setup-go@v3
with:
go-version: ${{ inputs.go-version }}
```
If kubernetes module code isn't changed, the kubernetes ci won't be triggered. So you can add a empty line in the file `https://github.com/apache/incubator-uniffle/blob/master/deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go` to trigger kubernetes CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293373832
##########
.github/workflows/build.yml:
##########
@@ -55,7 +60,7 @@ jobs:
java-11:
needs: [spotbugs] # delay execution
- name: 'compile'
+ name: 'compile-java11'
Review Comment:
Could we revert this change? We tell the difference by the other parameter.
<img width="295" alt="企业微信截图_2e4e5c92-42cb-4d98-acef-de26dade4153" src="https://github.com/apache/incubator-uniffle/assets/8159038/f9f85205-49b3-400e-8452-e8572dfad0e5">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293374153
##########
.github/workflows/build.yml:
##########
@@ -64,7 +69,7 @@ jobs:
java-17:
needs: [spotbugs] # delay execution
- name: 'compile'
+ name: 'compile-java17'
Review Comment:
Could we revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293614778
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
+ set -e
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#issuecomment-1678741905
> `Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.578 s <<< FAILURE! - in org.apache.tez.runtime.library.common.shuffle.orderedgrouped.RssShuffleTest Error: testSchedulerTerminatesOnException Time elapsed: 0.467 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: <false> but was: <true> at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40) at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:35) at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:227) at org.apache.tez.runtime.library.common.shuffle.orderedgrouped.RssShuffleTest.testSchedulerTerminatesOnException(RssShuffleTest.java:93) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.M
ethod.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131) at org.junit.jupiter.engine.extension.TimeoutInvocation.proceed(TimeoutInvocation.java:46) at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84) at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115) at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105) at org.junit.jupiter.engine.executi
on.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37) at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104) at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210) at org.junit.jupiter.engine.descriptor.T
estMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:9
5) at java.util.ArrayList.forEach(ArrayList.java:1259) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeT
estTask.execute(NodeTestTask.java:95) at java.util.ArrayList.forEach(ArrayList.java:1259) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platfor
m.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35) at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57) at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecu
tionOrchestrator.java:52) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86) at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86) at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:53) at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:150) at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)`
>
> I have'nt made changes to any tests but the pipeline is failing at that step.
It's irrelevant error. You can ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1287118800
##########
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go:
##########
@@ -359,7 +359,7 @@ type RemoteShuffleService struct {
//+kubebuilder:object:root=true
-// RemoteShuffleServiceList contains a list of RemoteShuffleService
+// RemoteShuffleServiceList contains a list of RemoteShuffleService
Review Comment:
Please revert unrelated changes.
```suggestion
// RemoteShuffleServiceList contains a list of RemoteShuffleService
```
##########
.github/workflows/single.yml:
##########
@@ -79,7 +79,7 @@ jobs:
go-version: ${{ inputs.go-version }}
- name: Execute `mvn ${{ inputs.maven-args }}`
run: mvn -B -fae ${{ inputs.maven-args }} | tee /tmp/maven.log
- shell: bash
+ shell: bash
Review Comment:
Please revert unrelated changes.
```suggestion
shell: bash
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293336544
##########
.github/workflows/build.yml:
##########
@@ -17,7 +17,32 @@
name: build
-on: [push, pull_request]
+on:
Review Comment:
It's necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293617863
##########
.github/workflows/build.yml:
##########
@@ -64,7 +69,7 @@ jobs:
java-17:
needs: [spotbugs] # delay execution
- name: 'compile'
+ name: 'compile-java17'
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293360357
##########
.github/workflows/build.yml:
##########
@@ -17,7 +17,32 @@
name: build
-on: [push, pull_request]
+on:
Review Comment:
done. added them and also the variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1335623654
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,34 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ cd deploy/kubernetes/integration-test/e2e && ./start-e2e.sh
Review Comment:
@jerqi can we merge this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293615979
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
Review Comment:
The path isn't correct. You can see the script
<img width="443" alt="企业微信截图_9bbe8da5-edcc-4afd-8014-3dd01018e185" src="https://github.com/apache/incubator-uniffle/assets/8159038/e0427657-25df-4091-b8ab-0c57cd1f9713">
You should run the command
```
cd deploy/kubernetes/integration-test/e2e && sh start-e2e.sh
```
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
Review Comment:
The path isn't correct. You can see the script
<img width="443" alt="企业微信截图_9bbe8da5-edcc-4afd-8014-3dd01018e185" src="https://github.com/apache/incubator-uniffle/assets/8159038/e0427657-25df-4091-b8ab-0c57cd1f9713">
You should run the command
```
cd deploy/kubernetes/integration-test/e2e && sh start-e2e.sh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1294449160
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,34 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ cd deploy/kubernetes/integration-test/e2e && ./start-e2e.sh
Review Comment:
There is a bash error. I will fix the issue of the bash.
<img width="626" alt="企业微信截图_0369d22e-ebce-47f2-8f55-46bf2a64edad" src="https://github.com/apache/incubator-uniffle/assets/8159038/0441ae12-5d74-4b72-9ae2-234301903833">
Let me use the command and I will merge this pr first.
```
cd deploy/kubernetes/integration-test/e2e && echo "execute e2e tests"
```
And then I will fix the script later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293683692
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
Review Comment:
done
> The path isn't correct. You can see the script <img alt="企业微信截图_9bbe8da5-edcc-4afd-8014-3dd01018e185" width="443" src="https://user-images.githubusercontent.com/8159038/260491114-e0427657-25df-4091-b8ab-0c57cd1f9713.png"> You should run the command
>
> ```
> cd deploy/kubernetes/integration-test/e2e && sh start-e2e.sh
> ```
Ya, i just saw the shell script. It is not taking that path. pushed the same change.
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
Review Comment:
done
> The path isn't correct. You can see the script <img alt="企业微信截图_9bbe8da5-edcc-4afd-8014-3dd01018e185" width="443" src="https://user-images.githubusercontent.com/8159038/260491114-e0427657-25df-4091-b8ab-0c57cd1f9713.png"> You should run the command
>
> ```
> cd deploy/kubernetes/integration-test/e2e && sh start-e2e.sh
> ```
Ya, i just saw the shell script. It is not taking that path. pushed the same change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293336544
##########
.github/workflows/build.yml:
##########
@@ -17,7 +17,32 @@
name: build
-on: [push, pull_request]
+on:
Review Comment:
It's necessary. Now the config of pipeline can't trigger ci pipeline. I doubt it's caused by this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] krishnaduttPanchagnula commented on pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "krishnaduttPanchagnula (via GitHub)" <gi...@apache.org>.
krishnaduttPanchagnula commented on PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#issuecomment-1678678744
`Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.578 s <<< FAILURE! - in org.apache.tez.runtime.library.common.shuffle.orderedgrouped.RssShuffleTest
Error: testSchedulerTerminatesOnException Time elapsed: 0.467 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40)
at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:35)
at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:227)
at org.apache.tez.runtime.library.common.shuffle.orderedgrouped.RssShuffleTest.testSchedulerTerminatesOnException(RssShuffleTest.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at org.junit.jupiter.engine.extension.TimeoutInvocation.proceed(TimeoutInvocation.java:46)
at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:53)
at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:150)
at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)`
I have'nt changes any tests but the pipeline is failing at that step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1113: [#1096] chore(ci): add kubernetes integration test to the pipeline
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1113:
URL: https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293382816
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs -DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
Review Comment:
We don't need to change the permission. We can use the command to run the shell
```
sh ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org