You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ellisms (via GitHub)" <gi...@apache.org> on 2025/05/27 18:09:22 UTC

[PR] Base redshift [airflow]

ellisms opened a new pull request, #51129:
URL: https://github.com/apache/airflow/pull/51129

   
   ---
   Updated the Redshift cluster operators and sensors to inherit the base AWS classes.
   Related to #35278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Redshift cluster operator and sensor to inherit AwsBaseOperator [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #51129:
URL: https://github.com/apache/airflow/pull/51129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Redshift cluster operator and sensor to inherit AwsBaseOperator [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #51129:
URL: https://github.com/apache/airflow/pull/51129#discussion_r2110061465


##########
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_cluster.py:
##########
@@ -219,15 +226,14 @@ def __init__(
         self.availability_zone_relocation = availability_zone_relocation
         self.aqua_configuration_status = aqua_configuration_status
         self.default_iam_role_arn = default_iam_role_arn
-        self.aws_conn_id = aws_conn_id
         self.wait_for_completion = wait_for_completion
         self.max_attempt = max_attempt
         self.poll_interval = poll_interval
         self.deferrable = deferrable
         self.kwargs = kwargs
 
     def execute(self, context: Context):
-        redshift_hook = RedshiftHook(aws_conn_id=self.aws_conn_id)
+        # redshift_hook = RedshiftHook(aws_conn_id=self.aws_conn_id)

Review Comment:
   Remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org