You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by vm...@apache.org on 2001/11/16 20:19:44 UTC
cvs commit: jakarta-cactus/src/framework/share/org/apache/cactus/server AbstractTestCaller.java
vmassol 01/11/16 11:19:44
Modified: src/framework/share/org/apache/cactus/server
AbstractTestCaller.java
Log:
removed explicit logging of entries and exits of methods (using aspectj now)
Revision Changes Path
1.5 +13 -24 jakarta-cactus/src/framework/share/org/apache/cactus/server/AbstractTestCaller.java
Index: AbstractTestCaller.java
===================================================================
RCS file: /home/cvs/jakarta-cactus/src/framework/share/org/apache/cactus/server/AbstractTestCaller.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- AbstractTestCaller.java 2001/10/20 10:18:06 1.4
+++ AbstractTestCaller.java 2001/11/16 19:19:44 1.5
@@ -71,7 +71,7 @@
*
* @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
*
- * @version $Id: AbstractTestCaller.java,v 1.4 2001/10/20 10:18:06 vmassol Exp $
+ * @version $Id: AbstractTestCaller.java,v 1.5 2001/11/16 19:19:44 vmassol Exp $
*/
public abstract class AbstractTestCaller
{
@@ -120,8 +120,6 @@
*/
public void doTest() throws ServletException
{
- logger.entry("doTest()");
-
WebTestResult result = null;
try {
@@ -154,8 +152,6 @@
result);
logger.debug("Result saved in context scope");
-
- logger.exit("doTest");
}
/**
@@ -165,8 +161,6 @@
*/
public void doGetResults() throws ServletException
{
- logger.entry("doGetResults()");
-
// One could think there is a potential risk that the client side of
// Cactus will request the result before it has been written to the
// context scope as the HTTP request will not block in some containers.
@@ -200,8 +194,19 @@
logger.error(message, e);
throw new ServletException(message, e);
}
+ }
- logger.exit("doGetResults");
+ /**
+ * Run the connection test between client and server. This is just to
+ * ensure that configuration is set up correctly.
+ *
+ * @exception ServletException if an unexpected error occurred
+ */
+ public void doRunTest() throws ServletException
+ {
+ // Do not return any http response (not needed). It is enough to
+ // know this point has been reached ... it means the connection has
+ // been established !
}
/**
@@ -209,8 +214,6 @@
*/
protected String getTestClassName() throws ServletException
{
- logger.entry("getTestClassName()");
-
String queryString =
this.webImplicitObjects.getHttpServletRequest().getQueryString();
String className = ServletUtil.getQueryStringParameter(queryString,
@@ -225,7 +228,6 @@
logger.debug("Class to call = " + className);
- logger.exit("getTestClassName");
return className;
}
@@ -235,8 +237,6 @@
*/
protected String getTestMethodName() throws ServletException
{
- logger.entry("getTestMethodName()");
-
String queryString =
this.webImplicitObjects.getHttpServletRequest().getQueryString();
String methodName = ServletUtil.getQueryStringParameter(queryString,
@@ -251,7 +251,6 @@
logger.debug("Method to call = " + methodName);
- logger.exit("getTestMethodName");
return methodName;
}
@@ -261,8 +260,6 @@
*/
protected boolean isAutoSession()
{
- logger.entry("isAutoSession()");
-
String queryString =
this.webImplicitObjects.getHttpServletRequest().getQueryString();
String autoSession = ServletUtil.getQueryStringParameter(queryString,
@@ -272,7 +269,6 @@
logger.debug("Auto session is " + isAutomaticSession);
- logger.exit("isAutoSession");
return isAutomaticSession;
}
@@ -284,9 +280,6 @@
protected AbstractTestCase getTestClassInstance(String theClassName,
String theTestCaseName) throws ServletException
{
- logger.entry("getTestClassInstance([" + theClassName + "], [" +
- theTestCaseName + "])");
-
// Print info on the classloader used to load this class
if (logger.isDebugEnabled()) {
StringBuffer buffer = new StringBuffer("Classloaders = ");
@@ -316,7 +309,6 @@
throw new ServletException(message, e);
}
- logger.exit("getTestClassInstance");
return testInstance;
}
@@ -328,8 +320,6 @@
protected Class getTestClassClass(String theClassName)
throws ServletException
{
- logger.entry("getTestClassClass([" + theClassName + "])");
-
// Get the class to call and build an instance of it.
Class testClass = null;
try {
@@ -349,7 +339,6 @@
throw new ServletException(message, e);
}
- logger.exit("getTestClassClass");
return testClass;
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>