You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/03/10 23:49:24 UTC

Re: Review Request 17720: OOZIE-1678 HA support for SLA

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review36721
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java
<https://reviews.apache.org/r/17720/#comment67804>

    is this 5000ms the timeout to requeue some  command? I think 5 seconds might be too short an interval



core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/17720/#comment67810>

    why is this initialized sometimes to false, sometimes to true, in different functions?



core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java
<https://reviews.apache.org/r/17720/#comment67811>

    can you include the fix to this forever looping function that we discussed offline to fix its flakiness?


- Mona Chitnis


On Feb. 27, 2014, 5:16 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 5:16 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/event/EventQueue.java 39156d6 
>   core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java f32afb4 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 4207a07 
>   core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2458e69 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>