[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1133: [KYUUBI #884][FOLLOWUP] Fix catalog in KyuubiDatabaseMetaData#getTables

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #1133:
URL: https://github.com/apache/incubator-kyuubi/pull/1133#discussion_r713802024



##########
File path: kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/KyuubiDatabaseMetaData.java
##########
@@ -60,11 +60,10 @@ public ResultSet getTables(String catalog, String schemaPattern,
         if (tStatus.getStatusCode() != TStatusCode.SUCCESS_STATUS) {
             throw new HiveSQLException(tStatus);
         }
-        new HiveQueryResultSet.Builder(conn)
+        return new HiveQueryResultSet.Builder(conn)
                 .setClient(client)
                 .setSessionHandle(sessHandle)
                 .setStmtHandle(getTableResp.getOperationHandle())
                 .build();
-        return super.getTables(catalog, schemaPattern, tableNamePattern, types);

Review comment:
       Iet's update in the PR desc then




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org