You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/16 18:39:32 UTC
[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
patacongo opened a new pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300
## Summary
Add support for decoding interrupt and system call instrumentation
## Impact
None other than to system/sched_note/note_main.c.
## Testing
Tested with sim:nsh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-645312145
@Ouss4 each commit hshould have a commit title with a short description and a body with an explanation for the commit
Example:
commit -asm "Short title for my commit
This is a commit description for my commit explaining why I need to modify the code or what the commit does."
If you run git log in the nuttx git you will see that some commits have just 1 line message (title) while others have several lines a title and a commit message.
This is a best parctice that helps us better document the commits in any project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea edited a comment on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-645312145
@Ouss4 each commit should have a commit title with a short description and a body with an explanation for the commit
Example:
commit -asm "Short title for my commit
This is a commit description for my commit explaining why I need to modify the code or what the commit does."
If you run git log in the nuttx git you will see that some commits have just 1 line message (title) while others have several lines a title and a commit message.
This is a best parctice that helps us better document the commits in any project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifier found
system/sched_note/note_main.c:653:0: error: No indentation line
system/sched_note/note_main.c:705:0: error: No indentation line
The first is the use of PRIdPTR from inttypes.h. The second two make no sense and are, most likely, errors in nxstyle.
2. The PR checks could fail until incubator-nuttx:#1259 is merged. The logic here depends on a definition added by that PR. Hmm... actually it probably will not fail because there is no configuration that builds this file. I have tested it with the PR 1259 and it does compile and work correctly if enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifier found
system/sched_note/note_main.c:653:0: error: No indentation line
system/sched_note/note_main.c:705:0: error: No indentation line
The first is the use of PRIdPTR from inttypes.h. The second two make no sense are are, most likely, errors in nxstyle.
2. The PR checks will fail until incubator-nuttx:#1259 is merged. It depends on a definition added by that PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-645312864
This is another example, from another well known project, how commits look with commit mesages
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=v5.7.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifier found
system/sched_note/note_main.c:653:0: error: No indentation line
system/sched_note/note_main.c:705:0: error: No indentation line
The first is the use of PRIdPTR from inttypes.h. The second two make no sense are are, most likely, errors in nxstyle.
2. The PR checks could fail until incubator-nuttx:#1259 is merged. The logic here depends on a definition added by that PR. Hmm... actually it probably will not fail because there is no configuration that builds this file. I have tested it with the PR 1259 and it does compile and work correctly if enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-645309183
> @ouss4 please add commit messages !
@jerpelea I'm not quite sure what you mean by that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-645191240
@ouss4 please add commit messages !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #300: system/sched_note/note_main.c: Add interrupt/syscall call decode.
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #300:
URL: https://github.com/apache/incubator-nuttx-apps/pull/300#issuecomment-644945111
Merge notes:
1. There are three nxstyle complaints that need to be ignored:
system/sched_note/note_main.c:609:64: error: Mixed case identifier found
system/sched_note/note_main.c:653:0: error: No indentation line
system/sched_note/note_main.c:705:0: error: No indentation line
The first is the use of PRIdPTR from inttypes.h. The second two make no sense are are, most likely, errors in nxstyle.
2. The PR checks will fail until incubator-nuttx:#1259 is merged. It depends on a definition added by that PR. Hmm... actually it probably will not fail because there is no configuration that builds this file. I have tested it with the PR 1259 and it does compile and work correctly if enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org