[GitHub] cbickel commented on a change in pull request #2810: Add couchdb clustering

[GitBox <gi...@apache.org>]

cbickel commented on a change in pull request #2810: Add couchdb clustering
URL: https://github.com/apache/incubator-openwhisk/pull/2810#discussion_r149659907
 
 

 ##########
 File path: ansible/roles/couchdb/tasks/deploy.yml
 ##########
 @@ -49,9 +63,48 @@
   retries: 12
   delay: 5
 
+- name: enable the cluster setup mode
+  uri:
+    url: "{{ db_protocol }}://{{ ansible_host }}:{{ db_port }}/_cluster_setup"
+    method: POST
+    body: >
+        {"action": "enable_cluster", "bind_address":"0.0.0.0", "username": "{{ db_username }}", "password":"{{ db_password }}", "port": {{ db_port }}, "node_count": "{{ num_instances }}", "remote_node": "{{ ansible_host }}", "remote_current_user": "{{ db_username }}", "remote_current_password": "{{ db_password }}"}
 
 Review comment:
   What about using
   ```
   {{ groups['db'] | length }}
   ```
   Instead of defining `num_instances` on the top?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services