You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "yanjin24 (via GitHub)" <gi...@apache.org> on 2026/09/25 08:18:39 UTC

[PR] [hotfix][config] Fix incorrect example keys in config.yaml [flink]

yanjin24 opened a new pull request, #29288:
URL: https://github.com/apache/flink/pull/29288

   ## What is the purpose of the change
   
   Fixes three broken examples in the shipped `config.yaml` template:
   
   1. The HistoryServer example nests `fs.refresh-interval` under `historyserver.archive.fs`, which flattens to the non-existent key `historyserver.archive.fs.fs.refresh-interval` and therefore never takes effect.
   2. The commented `jobmanager` block in the HistoryServer section clashes with the active top-level `jobmanager` key: uncommenting it makes the whole file fail to parse with a `DuplicateKeyException`.
   3. Same for the commented `taskmanager` block in the Advanced section.
   
   ## Brief change log
   
     - `fs.refresh-interval: 10000` → `refresh-interval: 10000`
     - Express the `jobmanager.archive.fs.dir` and `taskmanager.memory.network.*` examples in flat key form (e.g. `jobmanager.archive.fs.dir: hdfs:///completed-jobs/`). The flat form is documented as equivalent to the nested form, matches the HistoryServer docs page, and can be uncommented in place without clashing with the active top-level keys.
   
   ## Verifying this change
   
   Comment-only change in a resource template; no tests affected. Manually verified that a config combining the active top-level sections with the (uncommented) fixed examples parses without errors and flattens to exactly `jobmanager.archive.fs.dir`, `historyserver.archive.fs.refresh-interval`, and `taskmanager.memory.network.*`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix][config] Fix incorrect example keys in config.yaml [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29288:
URL: https://github.com/apache/flink/pull/29288#issuecomment-5829491722

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c964f4394298feb45d311b090966b23653bc1887",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c964f4394298feb45d311b090966b23653bc1887",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c964f4394298feb45d311b090966b23653bc1887 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org