You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/29 19:44:40 UTC
[GitHub] [hudi] harsh1231 opened a new pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
harsh1231 opened a new pull request #5170:
URL: https://github.com/apache/hudi/pull/5170
Support for spark datasource options in S3EventsHoodieIncrSource
While reading from spark file datasource, reader options could be provided in deltastreamer like
```- --hoodie-conf hoodie.deltastreamer.source.hoodieincr.spark.datasource.options={"header":"true","encoding":"UTF-8"}```
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082341621
> Have you tested the patch ?
@nsivabalan Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082307869
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082339739
> Have you tested the patch ?
Yes
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082361287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
}, {
"hash" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7525",
"triggerID" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
* 9267c4b23e411349a4be9556a44e37f31dedd5ac Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7525)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082336759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#discussion_r837861114
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -174,7 +180,19 @@ public S3EventsHoodieIncrSource(
}
Option<Dataset<Row>> dataset = Option.empty();
if (!cloudFiles.isEmpty()) {
- dataset = Option.of(sparkSession.read().format(fileFormat).load(cloudFiles.toArray(new String[0])));
+ DataFrameReader dataFrameReader = sparkSession.read().format(fileFormat);
+ if (!StringUtils.isNullOrEmpty(props.getString(HoodieIncrSource.Config.SPARK_DATASOURCE_OPTIONS, null))) {
Review comment:
can we move this to a private method and keep this cleaner/leaner.
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java
##########
@@ -88,6 +88,13 @@
* {@value #SOURCE_FILE_FORMAT} is passed to the reader while loading dataset. Default value is parquet.
*/
static final String SOURCE_FILE_FORMAT = "hoodie.deltastreamer.source.hoodieincr.file.format";
+ /**
+ *{@value #SPARK_DATASOURCE_OPTIONS} is json string, passed to the reader while loading dataset.
Review comment:
this may not be applicable to HoodieIncrSource. this is something specific to S3 incr source. So, can we move this to the other class ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082307869
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#discussion_r837880142
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java
##########
@@ -88,6 +88,13 @@
* {@value #SOURCE_FILE_FORMAT} is passed to the reader while loading dataset. Default value is parquet.
*/
static final String SOURCE_FILE_FORMAT = "hoodie.deltastreamer.source.hoodieincr.file.format";
+ /**
+ *{@value #SPARK_DATASOURCE_OPTIONS} is json string, passed to the reader while loading dataset.
Review comment:
Done
Patch is tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082333952
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082353688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
}, {
"hash" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
* 9267c4b23e411349a4be9556a44e37f31dedd5ac UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082353688
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
}, {
"hash" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
* 9267c4b23e411349a4be9556a44e37f31dedd5ac UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082440923
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
}, {
"hash" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7525",
"triggerID" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
* 9267c4b23e411349a4be9556a44e37f31dedd5ac Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7525)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082361287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
}, {
"hash" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7525",
"triggerID" : "9267c4b23e411349a4be9556a44e37f31dedd5ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
* 9267c4b23e411349a4be9556a44e37f31dedd5ac Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7525)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082336759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082310550
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #5170:
URL: https://github.com/apache/hudi/pull/5170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#discussion_r837883740
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -71,6 +75,12 @@
static final String S3_IGNORE_KEY_PREFIX = "hoodie.deltastreamer.source.s3incr.ignore.key.prefix";
// control whether to ignore the s3 objects with this substring
static final String S3_IGNORE_KEY_SUBSTRING = "hoodie.deltastreamer.source.s3incr.ignore.key.substring";
+ /**
+ *{@value #SPARK_DATASOURCE_OPTIONS} is json string, passed to the reader while loading dataset.
+ * Example delta streamer conf
+ * - --hoodie-conf hoodie.deltastreamer.source.hoodieincr.spark.datasource.options={"header":"true","encoding":"UTF-8"}
Review comment:
sorry. lets fix the config name.
hoodie.deltastreamer.source.s3incr.spark.datasource.options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082333952
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
}, {
"hash" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5721b6086f439a09eb9d94ffbd09d53f083e1316",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
* 5721b6086f439a09eb9d94ffbd09d53f083e1316 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 removed a comment on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
harsh1231 removed a comment on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082339739
> Have you tested the patch ?
Yes
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5170: [HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5170:
URL: https://github.com/apache/hudi/pull/5170#issuecomment-1082310550
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524",
"triggerID" : "02d5b4b9dc2eeb87fd413f40398b064904df7fff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02d5b4b9dc2eeb87fd413f40398b064904df7fff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7524)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org