[jira] [Commented] (CALCITE-784) LogicalAggregate's create method discards any collation traits from input

["Milinda Lakmal Pathirage (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646149#comment-14646149 ] 

Milinda Lakmal Pathirage commented on CALCITE-784:
--------------------------------------------------

As per the [~maryannxue]'s comment on CALCITE-783, it is not straitforward to infer collation properties of LogicalAggregate from input's collation. And for the purpose of implementing physical plan for group by based streaming tumbling windows, having input's (input to LogicalAggregate) collation metadata should be sufficient.

> LogicalAggregate's create method discards any collation traits from input
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-784
>                 URL: https://issues.apache.org/jira/browse/CALCITE-784
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Milinda Lakmal Pathirage
>            Assignee: Julian Hyde
>         Attachments: CALCITE-784-0.patch
>
>
> LogicalAggregate's create method gets the trait set of Convention.NONE from input's cluster, but doesn't use any trait information from the input. But to have proper collation trait set we need to consider input's collation trait set when inferring LogicalAggregate's traits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)