You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Robbie Gemmell <ro...@gmail.com> on 2017/02/06 17:11:33 UTC
Re: qpid-proton git commit: PROTON-1344: Added missed
PN_LISTENER_ACCEPT event from pn_event_type_name()
This should have its own JIRA given PROTON-1344 was already released
in 0.16.0 several weeks ago (and this also missed 0.17.0 too)
On 3 February 2017 at 20:44, <as...@apache.org> wrote:
> Repository: qpid-proton
> Updated Branches:
> refs/heads/master 4185261b7 -> 66d8f0e9c
>
>
> PROTON-1344: Added missed PN_LISTENER_ACCEPT event from pn_event_type_name()
>
>
> Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
> Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/66d8f0e9
> Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/66d8f0e9
> Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/66d8f0e9
>
> Branch: refs/heads/master
> Commit: 66d8f0e9c493419f27ff63f47dd7a707efc28e80
> Parents: 4185261
> Author: Andrew Stitcher <as...@apache.org>
> Authored: Mon Jan 23 12:30:53 2017 -0500
> Committer: Andrew Stitcher <as...@apache.org>
> Committed: Fri Feb 3 15:43:06 2017 -0500
>
> ----------------------------------------------------------------------
> proton-c/src/core/event.c | 2 ++
> 1 file changed, 2 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/66d8f0e9/proton-c/src/core/event.c
> ----------------------------------------------------------------------
> diff --git a/proton-c/src/core/event.c b/proton-c/src/core/event.c
> index 54fdee7..41ff6d1 100644
> --- a/proton-c/src/core/event.c
> +++ b/proton-c/src/core/event.c
> @@ -385,6 +385,8 @@ const char *pn_event_type_name(pn_event_type_t type)
> return "PN_SELECTABLE_FINAL";
> case PN_CONNECTION_WAKE:
> return "PN_CONNECTION_WAKE";
> + case PN_LISTENER_ACCEPT:
> + return "PN_LISTENER_ACCEPT";
> case PN_LISTENER_CLOSE:
> return "PN_LISTENER_CLOSE";
> case PN_PROACTOR_INTERRUPT:
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
> For additional commands, e-mail: commits-help@qpid.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: qpid-proton git commit: PROTON-1344: Added missed
PN_LISTENER_ACCEPT event from pn_event_type_name()
Posted by Robbie Gemmell <ro...@gmail.com>.
On 6 February 2017 at 18:10, Andrew Stitcher <as...@redhat.com> wrote:
> On Mon, 2017-02-06 at 17:28 +0000, Robbie Gemmell wrote:
>> On 6 February 2017 at 17:14, Andrew Stitcher <as...@apache.org>
>> wrote:
>> > On Mon, 2017-02-06 at 17:11 +0000, Robbie Gemmell wrote:
>> > > This should have its own JIRA given PROTON-1344 was already
>> > > released
>> > > in 0.16.0 several weeks ago (and this also missed 0.17.0 too)
>> >
>> > TBH it's such a small change that I'd have used NO-JIRA except that
>> > there was an obvious piece of work associated with it.
>> >
>> > Andrew
>> >
>>
>> Related JIRA is certainly better than NO-JIRA, though that would
>> still
>> preferably be in the same release as the original change, so I'd
>> likely have called use of that out too in this case. If its a trivial
>> change its likely a trivial JIRA too.
>>
>> Its nice to know whats in a given release, e.g I'm already thinking
>> of
>> 0.17.1. Maybe this would be worth being in that...but on the other
>> hand, if its not important enough to even warrant a JIRA, maybe not.
>
> It's mostly useful for debugging purposes more than anything else (and
> isn't exactly a bug per se), so I'd probably not bother with 0.17.1.
>
> [and now we've written almost 10x the lines of the actual change!]
>
Indeed, it might have been quicker just to raise a JIRA after all, as
well as better for folks looking to see what is in a given release and
why.
I see another commit just went in for the same closed JIRA, along with
a few more with no JIRA. When two thirds of the code changes pushed at
the same time don't have a JIRA for the next release, it doesn't seem
quite how things should be. Either a change is related to the other
commits that did have a JIRA, in which case use them, or they aren't
and then almost all of the time should have their own JIRA.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: qpid-proton git commit: PROTON-1344: Added missed
PN_LISTENER_ACCEPT event from pn_event_type_name()
Posted by Andrew Stitcher <as...@redhat.com>.
On Mon, 2017-02-06 at 17:28 +0000, Robbie Gemmell wrote:
> On 6 February 2017 at 17:14, Andrew Stitcher <as...@apache.org>
> wrote:
> > On Mon, 2017-02-06 at 17:11 +0000, Robbie Gemmell wrote:
> > > This should have its own JIRA given PROTON-1344 was already
> > > released
> > > in 0.16.0 several weeks ago (and this also missed 0.17.0 too)
> >
> > TBH it's such a small change that I'd have used NO-JIRA except that
> > there was an obvious piece of work associated with it.
> >
> > Andrew
> >
>
> Related JIRA is certainly better than NO-JIRA, though that would
> still
> preferably be in the same release as the original change, so I'd
> likely have called use of that out too in this case. If its a trivial
> change its likely a trivial JIRA too.
>
> Its nice to know whats in a given release, e.g I'm already thinking
> of
> 0.17.1. Maybe this would be worth being in that...but on the other
> hand, if its not important enough to even warrant a JIRA, maybe not.
It's mostly useful for debugging purposes more than anything else (and
isn't exactly a bug per se), so I'd probably not bother with 0.17.1.
[and now we've written almost 10x the lines of the actual change!]
Andrew
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: qpid-proton git commit: PROTON-1344: Added missed
PN_LISTENER_ACCEPT event from pn_event_type_name()
Posted by Robbie Gemmell <ro...@gmail.com>.
On 6 February 2017 at 17:14, Andrew Stitcher <as...@apache.org> wrote:
> On Mon, 2017-02-06 at 17:11 +0000, Robbie Gemmell wrote:
>> This should have its own JIRA given PROTON-1344 was already released
>> in 0.16.0 several weeks ago (and this also missed 0.17.0 too)
>
> TBH it's such a small change that I'd have used NO-JIRA except that
> there was an obvious piece of work associated with it.
>
> Andrew
>
Related JIRA is certainly better than NO-JIRA, though that would still
preferably be in the same release as the original change, so I'd
likely have called use of that out too in this case. If its a trivial
change its likely a trivial JIRA too.
Its nice to know whats in a given release, e.g I'm already thinking of
0.17.1. Maybe this would be worth being in that...but on the other
hand, if its not important enough to even warrant a JIRA, maybe not.
Robbie
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: qpid-proton git commit: PROTON-1344: Added missed
PN_LISTENER_ACCEPT event from pn_event_type_name()
Posted by Andrew Stitcher <as...@apache.org>.
On Mon, 2017-02-06 at 17:11 +0000, Robbie Gemmell wrote:
> This should have its own JIRA given PROTON-1344 was already released
> in 0.16.0 several weeks ago (and this also missed 0.17.0 too)
TBH it's such a small change that I'd have used NO-JIRA except that
there was an obvious piece of work associated with it.
Andrew
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org