[jira] [Commented] (OAK-1265) Add some more tests for o.a.j.o.security.authorization.evaluation.TreeTest

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870970#comment-13870970 ] 

angela commented on OAK-1265:
-----------------------------

applying the patch causes the following tests to fail:

Failed tests:   
- testGetPropertyCount(org.apache.jackrabbit.oak.security.authorization.evaluation.ChildOrderPropertyTest): expected:<2> but was:<3>
- testGetProperties(org.apache.jackrabbit.oak.security.authorization.evaluation.ChildOrderPropertyTest)

[~asanso], may i ask you to review your patch? thanks. also i would like to kindly ask you to run the build and verify if your patches don't cause any regressions *before* providing a patch.


> Add some more tests for o.a.j.o.security.authorization.evaluation.TreeTest
> --------------------------------------------------------------------------
>
>                 Key: OAK-1265
>                 URL: https://issues.apache.org/jira/browse/OAK-1265
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Antonio Sanso
>         Attachments: OAK-1265-patch.txt
>
>
> o.a.j.o.security.authorization.evaluation.TreeTest contains some TODO with some missing Test.
> This is a first patch that attempts to extend the test coverage for this class.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)