You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by abellina <gi...@git.apache.org> on 2016/08/29 14:24:39 UTC

[GitHub] storm pull request #1650: STORM-2064: add function, storm name and auth resu...

GitHub user abellina opened a pull request:

    https://github.com/apache/storm/pull/1650

    STORM-2064: add function, storm name and auth result to thrift access\u2026

    \u2026 log
    
    Apparently the 1.x-branch build was broken completely due to an issue with the storm-submit-tools pom.xml. Fixed that.
    
    The actual PR is for improvement to logging in DRPC and thrift access:
    
    drpc logs now show the function:
    
    2016-08-29 09:08:27.571 o.a.s.l.ThriftAccessLogger [INFO] Request ID: 5 access from: [ip]  principal: [principal] operation: fetchRequest **function: exclamation**
    
    nimbus logs now show the access result:
    
    2016-08-29 09:20:48.489 o.a.s.l.ThriftAccessLogger [INFO] Request ID: 24 access from: [ip]  principal: [principal] operation: getClusterInfo **access result: access-granted**
    
    and the storm-name, if looking at a topology:
    
    2016-08-29 09:22:32.474 o.a.s.l.ThriftAccessLogger [INFO] Request ID: 17 access from: [ip]  principal: [principal] operation: getTopologyConf **storm-name: wc access result: access-granted**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/abellina/storm STORM-2064_add_function_result_and_storm_name_to_access_log

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1650
    
----
commit d2fac932aba32a27c700a2f381a7380245742b5d
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Date:   2016-08-29T13:00:23Z

    STORM-2064: add function, storm name and auth result to thrift access log

commit 3e9692494cb510cb19c996fa347fbb3a5082e667
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Date:   2016-08-29T14:19:39Z

    Fix 1.x build due to storm--submit-tools pointing at non-existing 1.1.1-SNAPSHOT

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1650: STORM-2064: add function, storm name and auth resu...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1650


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1650: STORM-2064: add function, storm name and auth result to t...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1650
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---