[GitHub] [arrow] thisisnic commented on pull request #35055: GH-34436: [R] Bindings for JSON Dataset

["thisisnic (via GitHub)" <gi...@apache.org>]

thisisnic commented on PR #35055:
URL: https://github.com/apache/arrow/pull/35055#issuecomment-1593671763

   > This is so close!
   > 
   > I know that we don't necessarily have a way to extract options that we set on a Dataset; however, I think we should add a test with an `open_dataset()` that passes some though (i.e., `use_threads` and/or `newlines_in_values` and/or `schema`), and if possible, test that they actually did something.
   
   Actually, I'm going to push back on this.  We don't test these options fully when reading CSV datasets, and given they relate to internal mechanisms of how things run not what is returned, it's going to be difficult to test here, and should be tested in the C++ anyway.  Happy to write tests to check that these options are passed through successfully though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org